Fix case-insensitive account files bypassing password validation #551
Codecov / codecov/project
succeeded
Aug 1, 2024 in 1s
34.05% (+0.00%) compared to 888d36e
View this Pull Request on Codecov
34.05% (+0.00%) compared to 888d36e
Details
Codecov Report
Attention: Patch coverage is 41.37931% with 17 lines in your changes missing coverage. Please review.
Project coverage is 34.05%. Comparing base (
888d36e) to head (30ad72d).
Additional details and impacted files
| Files | Coverage Δ | |
|---|---|---|
| ...world/gregs/voidps/engine/data/json/FileStorage.kt | 100.00% <100.00%> (ø) |
|
| .../gregs/voidps/engine/client/PlayerAccountLoader.kt | 69.69% <0.00%> (-2.18%) |
⬇️ |
| ...orld/gregs/voidps/network/login/PasswordManager.kt | 80.00% <83.33%> (-5.72%) |
⬇️ |
| ...oidps/engine/data/definition/AccountDefinitions.kt | 13.88% <6.66%> (-0.82%) |
⬇️ |
... and 4 files with indirect coverage changes
@@ Coverage Diff @@
## main #551 +/- ##
=========================================
Coverage 34.05% 34.05%
- Complexity 4764 4769 +5
=========================================
Files 1291 1291
Lines 42828 42837 +9
Branches 9159 9164 +5
=========================================
+ Hits 14584 14590 +6
- Misses 24979 24985 +6
+ Partials 3265 3262 -3 | Components | Coverage Δ | |
|---|---|---|
| Content | 27.48% <ø> (+<0.01%) |
⬆️ |
| Engine | 43.55% <11.76%> (-0.02%) |
⬇️ |
| Network | 71.28% <83.33%> (-0.02%) |
⬇️ |
Loading