Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case-insensitive account files bypassing password validation #551

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

GregHib
Copy link
Owner

@GregHib GregHib commented Jul 31, 2024

closes #548

Copy link

github-actions bot commented Jul 31, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 41.37931% with 17 lines in your changes missing coverage. Please review.

Project coverage is 34.05%. Comparing base (888d36e) to head (30ad72d).

Files Patch % Lines
...oidps/engine/data/definition/AccountDefinitions.kt 6.66% 14 Missing ⚠️
...orld/gregs/voidps/network/login/PasswordManager.kt 83.33% 1 Missing and 1 partial ⚠️
.../gregs/voidps/engine/client/PlayerAccountLoader.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
Files Coverage Δ
...world/gregs/voidps/engine/data/json/FileStorage.kt 100.00% <100.00%> (ø)
.../gregs/voidps/engine/client/PlayerAccountLoader.kt 69.69% <0.00%> (-2.18%) ⬇️
...orld/gregs/voidps/network/login/PasswordManager.kt 80.00% <83.33%> (-5.72%) ⬇️
...oidps/engine/data/definition/AccountDefinitions.kt 13.88% <6.66%> (-0.82%) ⬇️

... and 4 files with indirect coverage changes

@@            Coverage Diff            @@
##               main     #551   +/-   ##
=========================================
  Coverage     34.05%   34.05%           
- Complexity     4764     4769    +5     
=========================================
  Files          1291     1291           
  Lines         42828    42837    +9     
  Branches       9159     9164    +5     
=========================================
+ Hits          14584    14590    +6     
- Misses        24979    24985    +6     
+ Partials       3265     3262    -3     
Components Coverage Δ
Content 27.48% <ø> (+<0.01%) ⬆️
Engine 43.55% <11.76%> (-0.02%) ⬇️
Network 71.28% <83.33%> (-0.02%) ⬇️

@GregHib GregHib mentioned this pull request Aug 1, 2024
@GregHib GregHib merged commit d280b61 into main Aug 1, 2024
5 checks passed
@GregHib GregHib deleted the account-login branch August 1, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Username exploit
1 participant