Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

92_boundsPostprob #104

Draft
wants to merge 46 commits into
base: main
Choose a base branch
from
Draft

92_boundsPostprob #104

wants to merge 46 commits into from

Conversation

audreyyeoCH
Copy link
Collaborator

closes #92

Copy link
Contributor

github-actions bot commented May 24, 2024

🧪 Test coverage: 65.25%

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ----------------------------------
R/betadiff.R                59       0  100.00%
R/boundsPostprob.R          39       0  100.00%
R/boundsPredprob.R          28      28  0.00%    36-73
R/dbetabinom.R              57       3  94.74%   32, 62, 129
R/oc2.R                    162     162  0.00%    93-326
R/oc3.R                    146     146  0.00%    91-308
R/ocPostprob.R              99       4  95.96%   239-242
R/ocPostprobDist.R         109       0  100.00%
R/ocPredprob.R             182       4  97.80%   285-288
R/ocPredprobDist.R         235       3  98.72%   346-348
R/ocRctPostprobDist.R      154       4  97.40%   236-239
R/ocRctPredprobDist.R      283      55  80.57%   207-222, 225-240, 373-376, 403-421
R/plotBeta.R               107     107  0.00%    16-174
R/plotBounds.R              52      52  0.00%    33-90
R/plotDecision.R            79      79  0.00%    16-136
R/plotOc.R                  15      15  0.00%    16-36
R/postprob.R                29       1  96.55%   99
R/postprobDist.R            78       1  98.72%   208
R/predprob.R                24       0  100.00%
R/predprobDist.R           140       1  99.29%   269
R/runShinyPhase1b.R          4       4  0.00%    8-13
R/sumbetadiff.R             63      63  0.00%    24-101
R/sumTable.R                20      20  0.00%    25-48
TOTAL                     2164     752  65.25%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  --------
R/boundsPostprob.R       +8     -31  +100.00%
TOTAL                    +8     -31  +1.57%

Results for commit: 9b94bba

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@audreyyeoCH audreyyeoCH changed the title Merge remote-tracking branch 'origin/HEAD' 92_boundsPostprob May 24, 2024
Merge branch '92_boundsPostprob' of github.com:Genentech/phase1b into 92_boundsPostprob
Copy link
Contributor

github-actions bot commented May 24, 2024

Unit Tests Summary

    1 files     15 suites   11m 45s ⏱️
  113 tests   112 ✅ 0 💤 0 ❌ 1 🔥
1 233 runs  1 232 ✅ 0 💤 0 ❌ 1 🔥

For more details on these errors, see this check.

Results for commit c59c148.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 24, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
boundsPostProb 👶 $+0.06$ $+8$ $0$ $0$ $0$
boundsPredprob 👶 $+0.02$ $+1$ $0$ $0$ $+1$
ocPostprob 💔 $23.23$ $+31.09$ $0$ $0$ $0$ $0$
ocPostprobDist 💔 $0.46$ $+1.69$ $0$ $0$ $0$ $0$
ocPredprob 💔 $3.96$ $+4.67$ $0$ $0$ $0$ $0$
ocPredprobDist 💔 $49.13$ $+405.24$ $0$ $0$ $0$ $0$
ocRctPostprobDist 💔 $0.65$ $+2.46$ $0$ $0$ $0$ $0$
ocRctPredprobDist 💔 $27.20$ $+144.70$ $0$ $0$ $0$ $0$
predprobDist 💔 $1.14$ $+8.43$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
boundsPostProb 👶 $+0.06$ boundsPostProb_gives_correct_result_and_list
boundsPredprob 👶 $+0.02$ boundsPredprob_gives_correct_result_and_list
dbetabinom 💀 $0.01$ $-0.01$ dbetaMix_handles_edge_cases
dbetabinom 💀 $0.01$ $-0.01$ pbetaMix_works_for_edge_cases
ocPostprob 💔 $8.61$ $+12.45$ ocPostprob_gives_results_that_are_within_range_to_stats_pbinom
ocPostprob 💔 $4.57$ $+7.29$ the_PrEfficacy_increases_with_increase_Efficacy_looks
ocPostprob 💔 $5.19$ $+8.49$ the_PrFutility_increases_with_increase_futility_looks
ocPostprob 💔 $1.83$ $+2.52$ the_sum_of_Eff_Fut_Gray_zone_probabiliy_is_1
ocPredprob 💔 $3.54$ $+4.27$ the_PrEfficacy_increases_with_increase_Efficacy_looks
ocPredprobDist 💔 $12.71$ $+97.06$ ocPredprobDist_gives_correct_result_and_list_when_relativeDelta_FALSE
ocPredprobDist 💔 $13.26$ $+112.91$ ocPredprobDist_gives_correct_result_and_list_when_relativeDelta_TRUE
ocPredprobDist 💔 $5.19$ $+43.78$ ocPredprobDist_gives_higher_PrEfficacy_with_more_efficacy_looks
ocPredprobDist 💔 $17.95$ $+151.47$ ocPredprobDist_gives_higher_PrFutility_with_more_futility_looks
ocRctPostprobDist 💔 $0.26$ $+1.22$ ocRctPostprobDist_gives_higher_PrFutility_with_decreased_pE
ocRctPredprobDist 💔 $10.85$ $+57.71$ ocRctPredprobDist_gives_higher_PrEfficacy_with_increased_pE
ocRctPredprobDist 💔 $10.85$ $+57.65$ ocRctPredprobDist_gives_higher_PrFutility_with_decreased_pE
ocRctPredprobDist 💔 $5.44$ $+29.32$ the_sum_of_Eff_Fut_Gray_zone_probability_is_1
postprob 💀 $0.01$ $-0.01$ postprob_works_with_vector_x
postprobDist 💀 $0.01$ $-0.01$ postprobDist_works_with_vector_x
predprobDist 💔 $0.20$ $+1.39$ h_predprobdist_gives_correct_list
predprobDist 💔 $0.32$ $+2.53$ h_predprobdist_gives_higher_predictive_probability_when_thetaT_is_lower
predprobDist 💔 $0.32$ $+2.54$ predprobDist_gives_higher_predictive_probability_when_thetaT_is_lower_in_a_single_arm_trial
predprobDist 💔 $0.17$ $+1.28$ predprobDist_gives_the_correct_results_in_a_two_arm_study

Results for commit fa97300

♻️ This comment has been updated with latest results.

@audreyyeoCH
Copy link
Collaborator Author

Hi @danielinteractive , git checks are running but ready for a review, thanks!

Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @audreyyeoCH

R/boundsPostprob.R Outdated Show resolved Hide resolved
R/boundsPostprob.R Outdated Show resolved Hide resolved
examples/boundsPostprob.R Outdated Show resolved Hide resolved
tests/testthat/test-boundsPostProb.R Outdated Show resolved Hide resolved
tests/testthat/test-boundsPostProb.R Outdated Show resolved Hide resolved
@audreyyeoCH
Copy link
Collaborator Author

Hi @danielinteractive it's running git checks now, could you review please ?

R/dbetabinom.R Outdated Show resolved Hide resolved
examples/boundsPostprob.R Outdated Show resolved Hide resolved
tests/testthat/test-boundsPostProb.R Outdated Show resolved Hide resolved
@audreyyeoCH audreyyeoCH marked this pull request as draft September 24, 2024 08:40
@audreyyeoCH
Copy link
Collaborator Author

Just realised that this does not accept beta-mixtures, but can facilitate, will be added to current issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

92_boundsPostprob.R
2 participants