-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
109 my plot diff #110
base: main
Are you sure you want to change the base?
109 my plot diff #110
Conversation
Code Coverage Summary
Diff against main
Results for commit: 93f463a Minimum allowed coverage is ♻️ This comment has been updated with latest results |
the vintage example file is called |
Hi @danielinteractive, there's probably some design questions here on how we want the plot to look, could you review and share what do you think please ? The colours chosen are from a colour blind friendly template |
#' boundaries based on posterior probabilities, i.e.: | ||
#' Efficacy boundary: find minimum x (xU) where Pr(P>p0|x,n,a,b) >= tU and | ||
#' Futility boundary: find maximum x (xL) where Pr(P>p1|x,n,a,b) <= tL | ||
#' boundaries based on the following rules: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are a lot of changes here for boundsPostprob
, and I see there is still the PR #104 ongoing - it would be better to first get that done and then continue here with plotDiff
closes #109