Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

109 my plot diff #110

Draft
wants to merge 46 commits into
base: main
Choose a base branch
from
Draft

109 my plot diff #110

wants to merge 46 commits into from

Conversation

audreyyeoCH
Copy link
Collaborator

closes #109

Copy link
Contributor

github-actions bot commented Jun 11, 2024

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ----------------------------------
R/betadiff.R                59       0  100.00%
R/boundsPostprob.R          34       0  100.00%
R/boundsPredprob.R          28      28  0.00%    36-73
R/dbetabinom.R              81       3  96.30%   32, 62, 136
R/oc2.R                    162     162  0.00%    93-326
R/oc3.R                    146     146  0.00%    91-308
R/ocPostprob.R              99       4  95.96%   239-242
R/ocPostprobDist.R         109       0  100.00%
R/ocPredprob.R             182       4  97.80%   285-288
R/ocPredprobDist.R         235       3  98.72%   346-348
R/ocRctPostprobDist.R      154       4  97.40%   236-239
R/ocRctPredprobDist.R      283      55  80.57%   207-222, 225-240, 373-376, 403-421
R/plotBeta.R                51      38  25.49%   66-109
R/plotBounds.R              52      52  0.00%    33-90
R/plotDecision.R            79      79  0.00%    16-136
R/plotOc.R                  15      15  0.00%    16-36
R/postprob.R                34       1  97.06%   106
R/postprobDist.R            77       1  98.70%   204
R/predprob.R                24       0  100.00%
R/predprobDist.R           140       1  99.29%   269
R/runShinyPhase1b.R          4       4  0.00%    8-13
R/sumbetadiff.R             63      63  0.00%    24-101
R/sumTable.R                20      20  0.00%    25-48
TOTAL                     2131     683  67.95%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  --------
R/boundsPostprob.R       +3     -31  +100.00%
R/plotBeta.R            -52     -52  +12.87%
TOTAL                   -49     -83  +3.09%

Results for commit: 93f463a

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@audreyyeoCH
Copy link
Collaborator Author

audreyyeoCH commented Sep 22, 2024

the vintage example file is called myPlotDiff.R shows what was intended of this call which has been refactored to plotBetaDiff and has its own example file.

@audreyyeoCH
Copy link
Collaborator Author

Hi @danielinteractive, there's probably some design questions here on how we want the plot to look, could you review and share what do you think please ? The colours chosen are from a colour blind friendly template

@audreyyeoCH audreyyeoCH marked this pull request as draft September 23, 2024 12:44
#' boundaries based on posterior probabilities, i.e.:
#' Efficacy boundary: find minimum x (xU) where Pr(P>p0|x,n,a,b) >= tU and
#' Futility boundary: find maximum x (xL) where Pr(P>p1|x,n,a,b) <= tL
#' boundaries based on the following rules:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a lot of changes here for boundsPostprob, and I see there is still the PR #104 ongoing - it would be better to first get that done and then continue here with plotDiff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

109_myPlotDiff
2 participants