Allow overwrite file uploads and link file to submitted form

[lhalaa]

• Allow overwrite existing uploads - Add ability to re-upload a file #21
• Use hidden submission ID instead of session for partial page forms
• Show message when a file has already been uploaded and link file on submission - Show message a file has already been uploaded #27
• Refactor code for creating new submissions - Keep current partial submission instead of creating a new partial submission on session time-out #18

[codecov]

Codecov Report

Merging #32 into feature/space-form will decrease coverage by 1.15%.
The diff coverage is 72.81%.

@@                   Coverage Diff                    @@
##             feature/space-form      #32      +/-   ##
========================================================
- Coverage                 92.46%   91.31%   -1.16%     
- Complexity                  141      158      +17     
========================================================
  Files                        14       14              
  Lines                       478      541      +63     
========================================================
+ Hits                        442      494      +52     
- Misses                       36       47      +11

Impacted Files	Coverage Δ	Complexity Δ
src/models/PartialFileFieldSubmission.php	85.71% <ø> (+7.14%)	7 <0> (ø)	⬇️
src/extensions/SubmittedFormExtension.php	90% <100%> (+10%)	5 <0> (+2)	⬆️
...rc/controllers/PartialUserFormVerifyController.php	100% <100%> (ø)	7 <0> (ø)	⬇️
src/models/PartialFormSubmission.php	100% <100%> (+2.7%)	22 <5> (+4)	⬆️
.../extensions/UserDefinedFormControllerExtension.php	26.47% <21.87%> (-73.53%)	12 <11> (+11)
src/controllers/PartialSubmissionController.php	85.91% <83.33%> (-11.15%)	24 <4> (+1)
src/controllers/PartialUserFormController.php	89.83% <96.15%> (+39.83%)	16 <3> (-1)	⬇️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d79cef...d5faf40. Read the comment docs.

[Firesphere]

... This is quite a big lack of tests?

.../extensions/UserDefinedFormControllerExtension.php | 26.47% <21.87%> (-73.53%)
-- | --

[Firesphere]

Please merge in to Master and don't use a separate branch. As long as it's applicable to the module, using a separate branch is not ideal and will only add confusion

[lhalaa]

Please merge in to Master and don't use a separate branch. As long as it's applicable to the module, using a separate branch is not ideal and will only add confusion

Yeah we're planning to do reviews at our own time and so I created a separate branch. This will still go into Master once we're done. It would probably be better to fork the module so we can do our work at our own pace and get things done faster and then create a pull request here once we're done.