Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overwrite existing uploads #30

Closed
wants to merge 2 commits into from
Closed

Conversation

lhalaa
Copy link
Collaborator

@lhalaa lhalaa commented Sep 1, 2019

Resolves #21

@lhalaa lhalaa changed the title [WIP] Allow overwrite existing uploads Allow overwrite existing uploads Sep 1, 2019
@codecov
Copy link

codecov bot commented Sep 1, 2019

Codecov Report

Merging #30 into master will increase coverage by 5.25%.
The diff coverage is 89.47%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #30      +/-   ##
============================================
+ Coverage     90.65%   95.91%   +5.25%     
- Complexity      118      123       +5     
============================================
  Files            12       12              
  Lines           396      416      +20     
============================================
+ Hits            359      399      +40     
+ Misses           37       17      -20
Impacted Files Coverage Δ Complexity Δ
src/models/PartialFormSubmission.php 96.92% <100%> (+0.2%) 16 <1> (+1) ⬆️
src/controllers/PartialSubmissionController.php 95.71% <87.5%> (-1.35%) 23 <4> (ø)
src/controllers/PartialUserFormController.php 88% <88.46%> (+60.22%) 15 <3> (+4) ⬆️
src/models/PartialFileFieldSubmission.php 85.71% <0%> (+7.14%) 7% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2549254...a84a81c. Read the comment docs.

src/models/PartialFileFieldSubmission.php Outdated Show resolved Hide resolved
src/models/PartialFormSubmission.php Outdated Show resolved Hide resolved
@Firesphere
Copy link
Owner

Could you add some tests? It's better to keep the testing quality up than letting it go

@lhalaa
Copy link
Collaborator Author

lhalaa commented Sep 2, 2019

Could you add some tests? It's better to keep the testing quality up than letting it go

I won't have time to add all the tests, so my tests will be limited

@lhalaa
Copy link
Collaborator Author

lhalaa commented Sep 2, 2019

Moved to #32

@lhalaa lhalaa closed this Sep 2, 2019
@lhalaa lhalaa deleted the feature/replace-file branch September 2, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to re-upload a file
2 participants