Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate new form session from partial #31

Closed
wants to merge 3 commits into from

Conversation

lhalaa
Copy link
Collaborator

@lhalaa lhalaa commented Sep 2, 2019

Partial page forms will use hidden submission ID instead of session.
Uses #30

@codecov
Copy link

codecov bot commented Sep 2, 2019

Codecov Report

Merging #31 into master will increase coverage by 4.51%.
The diff coverage is 88.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #31      +/-   ##
============================================
+ Coverage     90.65%   95.17%   +4.51%     
- Complexity      118      132      +14     
============================================
  Files            12       12              
  Lines           396      435      +39     
============================================
+ Hits            359      414      +55     
+ Misses           37       21      -16
Impacted Files Coverage Δ Complexity Δ
src/models/PartialFormSubmission.php 97.14% <100%> (+0.42%) 20 <7> (+5) ⬆️
.../extensions/UserDefinedFormControllerExtension.php 72.72% <66.66%> (-27.28%) 7 <6> (+6)
src/controllers/PartialSubmissionController.php 94.44% <81.81%> (-2.62%) 24 <4> (+1)
src/controllers/PartialUserFormController.php 88.67% <90.9%> (+60.9%) 13 <3> (+2) ⬆️
src/models/PartialFileFieldSubmission.php 85.71% <0%> (+7.14%) 7% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2549254...eb3d717. Read the comment docs.

@lhalaa lhalaa closed this Sep 2, 2019
@lhalaa lhalaa deleted the feature/isolate-session branch September 2, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant