Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have to make sure this is in the migration guide!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! Indeed. Making a note of this (the other bits are in some Studio commit messages I`ll have to dig up)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, when I made
g2p -h
fast, I removed a lot of imports fromg2p/__init__.py
, so anything expecting those imports to work will need to be changed.You can see those changes in roedoejet/g2p@0b8d773
I could argue it was not great style to import just to expose, but that's irrelevant: if packages using g2p took advantage of that, we need to warn them!
And that makes me realize that commit really should have had a breaking change warning. I didn't think of those changes as breaking because we don't document anywhere that those imports were part of the API.