fix: adjust where g2p imports need to come from now #8
Conversation
When we optimized the g2p CLI to load fast, we removed a number of imports from g2p.__init__, so now we have to import those symbols from where they are actually defined. Fixes: EveryVoiceTTS/EveryVoice#323
|
| @@ -19,7 +19,9 @@ def __init__(self, sentence_list, transducer): | |||
|
|
|||
| def create_transducer(text, labels_dictionary, debug=False): | |||
| # deferred expensive imports | |||
| from g2p import CompositeTransducer, Mapping, Transducer, make_g2p | |||
| from g2p import make_g2p | |||
There was a problem hiding this comment.
We'll have to make sure this is in the migration guide!
There was a problem hiding this comment.
Ah! Indeed. Making a note of this (the other bits are in some Studio commit messages I`ll have to dig up)
There was a problem hiding this comment.
Yeah, when I made g2p -h fast, I removed a lot of imports from g2p/__init__.py, so anything expecting those imports to work will need to be changed.
You can see those changes in roedoejet/g2p@0b8d773
I could argue it was not great style to import just to expose, but that's irrelevant: if packages using g2p took advantage of that, we need to warn them!
And that makes me realize that commit really should have had a breaking change warning. I didn't think of those changes as breaking because we don't document anywhere that those imports were part of the API.
When we optimized the g2p CLI to load fast, we removed a number of imports from g2p.init, so now we have to import those symbols from where they are actually defined.
Fixes: EveryVoiceTTS/EveryVoice#323