Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: annotations on page #392

Closed
wants to merge 3 commits into from
Closed

Fix: annotations on page #392

wants to merge 3 commits into from

Conversation

bwbohl
Copy link
Member

@bwbohl bwbohl commented Jul 2, 2024

Some potential imrpvements:

  • change classes of "annotation" and "annotIcon"
  • push real annotations not the measure boxes that contain them to viewer.shapes annotations

add/index.xql Outdated Show resolved Hide resolved
@bwbohl bwbohl requested a review from riedde September 4, 2024 12:45
@bwbohl bwbohl modified the milestones: 1.0.0-beta.6, 1.0.0 Sep 4, 2024
@bwbohl bwbohl marked this pull request as draft September 7, 2024 10:09
@bwbohl bwbohl marked this pull request as ready for review September 7, 2024 10:10
@bwbohl
Copy link
Member Author

bwbohl commented Sep 7, 2024

merged with 98f15db

@bwbohl bwbohl closed this Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bugfix A pull request providing a bugfix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

OpenSeaDragonViewer: multiple instances of annotations annotations are added as duplicates
2 participants