Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSeaDragonViewer: multiple instances of annotations #388

Closed
bwbohl opened this issue Jun 20, 2024 · 2 comments
Closed

OpenSeaDragonViewer: multiple instances of annotations #388

bwbohl opened this issue Jun 20, 2024 · 2 comments
Assignees
Milestone

Comments

@bwbohl
Copy link
Member

bwbohl commented Jun 20, 2024

When showing and hiding annotations in OpenSearagonViewer multiple times, each time, the annotations are added to the view (but not deleted on hide, as in ImageViewer). This results in multiple instances of each annotation being displayed and consequently a failure of annotation previews and opening the annotation.

Apparently, this is due to the corresponding function being empty:

removeShapes: function() {
},

For testing:

  1. go to https://klarinettenquintett.weber-gesamtausgabe.de/
  2. open "Autograph A" from the navigator
  3. go to page 2
  4. In Menu "Anmerkungen" select "Anmerkungen ein-/ausblenden"
  5. check how the interface works
  6. repeat step 4 ad libidum
  7. see how the number of annotation icons duplicates
  8. try the interface

This is a critical bug!

@bwbohl bwbohl added this to the 1.0.0-beta.6 milestone Jun 20, 2024
@bwbohl
Copy link
Member Author

bwbohl commented Jun 20, 2024

@hizclick & @daniel-jettka this might be a good first issue ;-)

@bwbohl bwbohl self-assigned this Jun 26, 2024
@bwbohl bwbohl linked a pull request Jul 3, 2024 that will close this issue
2 tasks
@bwbohl bwbohl modified the milestones: 1.0.0-beta.6, 1.0.0 Sep 4, 2024
@bwbohl
Copy link
Member Author

bwbohl commented Sep 7, 2024

closed with 98f15db

@bwbohl bwbohl closed this as completed Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant