Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zipSigner dependency for intellijPlatform #46

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Jul 23, 2024

Fixes #44 (comment).

Execution failed for task ':idea-plugin:signPlugin'.
> No Marketplace ZIP Signer executable found.
  Please ensure the `zipSigner()` entry is present in the project dependencies section or `intellijPlatform.signing.cliPath` extension property
  See: https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-extension.html#intellijPlatform-signing

Fixes error:

```
Execution failed for task ':idea-plugin:signPlugin'.
> No Marketplace ZIP Signer executable found.
  Please ensure the `zipSigner()` entry is present in the project dependencies section or `intellijPlatform.signing.cliPath` extension property
  See: https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-extension.html#intellijPlatform-signing
```
@Goooler
Copy link
Member Author

Goooler commented Jul 23, 2024

./gradlew signPlugin fails on my device:

* What went wrong:
Could not determine the dependencies of task ':idea-plugin:buildSearchableOptions'.
> Failed to calculate the value of task ':idea-plugin:buildSearchableOptions' property 'sandboxPluginsDirectory'.
   > Failed to query the value of task ':idea-plugin:prepareSandbox' property 'sandboxPluginsDirectory'.
      > Failed to query the value of task ':idea-plugin:prepareSandbox' property 'sandboxDirectory'.
         > Cannot resolve 'product-info.json' with: '/Users/goooler/.gradle/caches/8.9/transforms/bcd634159af2052b928489697cb6dff8/transformed/ideaIC-2024.1-aarch64'

Can you try this on your device with signing secerts provided? @egorikftp

@Goooler
Copy link
Member Author

Goooler commented Jul 23, 2024

Have to remove this cache and run again:

rm -rf /Users/goooler/.gradle/caches/8.9/transforms/bcd634159af2052b928489697cb6dff8/transformed

gw build

Can you verify this works and signs distribution on your device? I have no sign secrets, it can't sign on my device, not sure this fix really work.

tree idea-plugin/build/distributions

idea-plugin/build/distributions
└── valkyrie-0.3.2-SNAPSHOT.zip

1 directory, 1 file

@Goooler Goooler marked this pull request as ready for review July 23, 2024 06:41
@egorikftp
Copy link
Member

@Goooler checked your changes in separate branch, looks fixed

https://github.com/ComposeGears/Valkyrie/actions/runs/10054111747/job/27788084126

@Goooler
Copy link
Member Author

Goooler commented Jul 23, 2024

Thanks!

@egorikftp egorikftp merged commit b147d8e into ComposeGears:main Jul 23, 2024
3 checks passed
@Goooler Goooler deleted the fix-plugin-signing branch July 23, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants