Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to IntelliJ Platform Gradle Plugin 2.0 RC #44

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Jul 23, 2024

@Goooler
Copy link
Member Author

Goooler commented Jul 23, 2024

We can't remove this workaround yet.

run {
// workaround for https://youtrack.jetbrains.com/issue/IDEA-285839/Classpath-clash-when-using-coroutines-in-an-unbundled-IntelliJ-plugin
buildPlugin {
exclude { "coroutines" in it.name }
archiveFileName = "${rootProject.name}-$version.zip"
}
prepareSandbox {
exclude { "coroutines" in it.name }
}
}

@Goooler Goooler force-pushed the jetbrains-intellij-plugin-2 branch from d350685 to ffa09e7 Compare July 23, 2024 01:39
@egorikftp egorikftp merged commit b9c0fdf into ComposeGears:main Jul 23, 2024
3 checks passed
@Goooler Goooler deleted the jetbrains-intellij-plugin-2 branch July 23, 2024 05:42
@Goooler
Copy link
Member Author

Goooler commented Jul 23, 2024

https://github.com/ComposeGears/Valkyrie/actions/runs/10053386801/job/27786217696

There is a signing-related error:

Execution failed for task ':idea-plugin:signPlugin'.
> No Marketplace ZIP Signer executable found.
  Please ensure the `zipSigner()` entry is present in the project dependencies section or `intellijPlatform.signing.cliPath` extension property
  See: https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-extension.html#intellijPlatform-signing

I'm trying to fix.

@Goooler
Copy link
Member Author

Goooler commented Jul 23, 2024

Addressed to #46.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants