Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ndarray to encapsulate view of Zarr array. #69

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Add Ndarray to encapsulate view of Zarr array. #69

merged 4 commits into from
Sep 6, 2024

Conversation

zoj613
Copy link
Owner

@zoj613 zoj613 commented Sep 5, 2024

First step towards replacing Owl as a dependency.

@zoj613 zoj613 added enhancement New feature or request codecs relating to codecs refactoring labels Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 94.17040% with 13 lines in your changes missing coverage. Please review.

Project coverage is 97.96%. Comparing base (864ad6d) to head (bc014ab).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
zarr/src/metadata.ml 78.57% 12 Missing ⚠️
zarr/src/ndarray.ml 98.64% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   97.81%   97.96%   +0.14%     
==========================================
  Files          17       18       +1     
  Lines        1235     1275      +40     
==========================================
+ Hits         1208     1249      +41     
+ Misses         27       26       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoj613 zoj613 force-pushed the ndarray branch 7 times, most recently from 5f40d00 to dac3a42 Compare September 6, 2024 21:16
This adds a module to encapsulate a view of a Zarr array. It
replaces that functionality provided by Owl.
This vendors owl's indexing logic for slicing an array so as to
not depend on the project at installation/build time, to make it
easy for zarr to be installed on many systems.
@zoj613 zoj613 merged commit 4792eb0 into main Sep 6, 2024
3 of 4 checks passed
@zoj613 zoj613 deleted the ndarray branch September 6, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codecs relating to codecs enhancement New feature or request refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant