Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce correct sequencing of codecs in codec chain. #65

Merged
merged 2 commits into from
Aug 31, 2024
Merged

Conversation

zoj613
Copy link
Owner

@zoj613 zoj613 commented Aug 31, 2024

This ensures that creation of a codec chain fails if the sequencing of codecs in the list is not correct. That is if the sequencing is not exactly: arraytoarray list -> 1 array-to-bytes -> bytestobytes list. That is one must supply the codecs in the order in which they intend to apply the encode/decode sequence.

This ensures that creation of a codec chain fails if the sequencing of
codecs in the list is not correct. That is if the sequencing is not
exactly: arraytoarray list -> 1 array-to-bytes -> bytestobytes list.
That is one must supply the codecs in the order in which they intend to
apply the encode/decode sequence.
@zoj613 zoj613 added codecs relating to codecs tests relating to tests labels Aug 31, 2024
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.80%. Comparing base (d50b2db) to head (b0d0e38).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
zarr/src/codecs/codecs.ml 90.90% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   97.81%   97.80%   -0.02%     
==========================================
  Files          17       17              
  Lines        1282     1275       -7     
==========================================
- Hits         1254     1247       -7     
  Misses         28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoj613 zoj613 merged commit 7da3c0c into main Aug 31, 2024
2 of 4 checks passed
@zoj613 zoj613 deleted the codec-order branch August 31, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codecs relating to codecs tests relating to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant