Optimize eio-based filesystem store abstract functions. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
==========================================
- Coverage 97.83% 97.80% -0.03%
==========================================
Files 17 17
Lines 1293 1278 -15
==========================================
- Hits 1265 1250 -15
Misses 28 28 ☔ View full report in Codecov by Sentry. |
Try to reuse allocated memory as much as possible.
Use as little buffer size as possible for reads/writes.
Minimize the number of Deferred.return calls.
`with_open path f` finalizes any changes made to the zip store and writes them to the store's path after the call to f exits.
Turn simple pattern matching involding option types into one-liner using Option.fold.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to reuse allocated memory as much as possible.