Minimize get_partial and set_partial calls.
#52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoj613
added
storage
zoj613
changed the title
get_partial & set_partial calls.get_partial and set_partial calls.
zoj613
force-pushed
the
batchread
branch
2 times, most recently
from
0717c52
to
712e7ae
Compare
calling these for every requested inner chunk of a shard is expensive can can lead to a `Unix.EMFILE` error. This commit attempts to minimize the number of calls by making sure these are called once on all requested inner chunks of a shard. This should lead to a significant decrease in the number of open files open for read/write at the same time when using a Zarr_lwt `FilesystemStore`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 97.50% 97.52% +0.02%
==========================================
Files 15 15
Lines 1160 1173 +13
==========================================
+ Hits 1131 1144 +13
Misses 29 29 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calling these for every requested inner chunk of a shard is expensive can can lead to a
Unix.EMFILEerror. This commit attempts to minimize the number of calls by making sure these are called once on all requested inner chunks of a shard. This should lead to a significant decrease in the number of open files open for read/write at the same time when using a Zarr_lwtFilesystemStore.