Make sharded arrays written by other implementations readable. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 97.56% 97.62% +0.05%
==========================================
Files 13 13
Lines 1150 1177 +27
==========================================
+ Hits 1122 1149 +27
Misses 28 28 ☔ View full report in Codecov by Sentry. |
Since bigarrays are limited to signed 64bit, sharding indexed could
not correctly read arrays using $2^{64} -1$ index values to represent
empty inner chunks. this commit fixes that issue.
This is to help the type checker rule out ShardingIndexed codec when pattern matching on array->bytes codecs used for the index_codec chain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #45
Since bigarrays are limited to signed 64bit, sharding indexed could not correctly read arrays using$2^{64} -1$ index values to represent empty inner chunks. this commit fixes that issue.