Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support optional chunk_key_encoding configuration. #29

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

zoj613
Copy link
Owner

@zoj613 zoj613 commented Jul 11, 2024

Ensures that optional chunk_key_encoding configuration is honored. If not specified a default value is used, and this default configuration is not written to the jSON when serializing a metadata type.

Ensures that optional chunk_key_encoding configuration is honored.
If not specified a default value is used, and this default configuration
is not written to the jSON when serializing a metadata type.
@zoj613 zoj613 added bug Something isn't working metadata relating to metadata tests relating to tests labels Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.01%. Comparing base (6589fb5) to head (d138ecf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   95.00%   95.01%   +0.01%     
==========================================
  Files          13       13              
  Lines        1081     1084       +3     
==========================================
+ Hits         1027     1030       +3     
  Misses         54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoj613 zoj613 merged commit e2bf47c into main Jul 11, 2024
4 checks passed
@zoj613 zoj613 deleted the optional_chunkkey branch July 11, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working metadata relating to metadata tests relating to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant