Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply small optimization to sharding decode. #28

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Apply small optimization to sharding decode. #28

merged 1 commit into from
Jul 10, 2024

Conversation

zoj613
Copy link
Owner

@zoj613 zoj613 commented Jul 10, 2024

  1. This ensures decoding of a shard doesn't fail by ensuring change in array representation due to transposing doesn't cause indexing errors.
  2. Empty shard inner chunks don't get created when reading a slice that includes them.

1. This ensures decoding of a shard doesn't fail by ensuring change
in array representation due to transposing doesn't cause indexing
errors.
2. Empty shard inner chunks don't get created when reading a slice
 that includes them.
@zoj613 zoj613 added codecs relating to codecs performance relating to performance labels Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.00%. Comparing base (aa31327) to head (0c87d7c).

Files Patch % Lines
lib/codecs/array_to_bytes.ml 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   94.82%   95.00%   +0.18%     
==========================================
  Files          13       13              
  Lines        1082     1081       -1     
==========================================
+ Hits         1026     1027       +1     
+ Misses         56       54       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoj613 zoj613 merged commit 6589fb5 into main Jul 10, 2024
3 of 4 checks passed
@zoj613 zoj613 deleted the sharding_opt branch July 10, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codecs relating to codecs performance relating to performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant