Remove unneeded json (de-)serialization code generators for codecs. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gzip and CRC32c codecs have a simple configuration that does not need code generators to implement correct json deserialization/serialization.
This allows us to do more thorough parsing of the configuration like checking for emptiness, value max and signedness of order elements when reading from a JSON document.
This manually implements the (de)serializatioin functions since they are not complicated. This allows for better error reporting messages.
zoj613
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
==========================================
+ Coverage 73.75% 80.00% +6.24%
==========================================
Files 13 13
Lines 1002 1010 +8
==========================================
+ Hits 739 808 +69
+ Misses 263 202 -61 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code generators to implement correct json deserialization/serialization.
like checking for emptiness, value max and signedness of order
elements when reading from a JSON document.
they are not complicated. This allows for better error reporting
messages.