Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tobias: Expose Trust#show with link to Payout#new #23

Open
wants to merge 8 commits into
base: tobias/issuing-payouts
Choose a base branch
from

Conversation

zspencer
Copy link
Member

@zspencer zspencer commented Feb 13, 2024

@zspencer zspencer requested a review from a team February 13, 2024 01:50
app/furniture/tobias.rb Outdated Show resolved Hide resolved
app/furniture/tobias/record.rb Outdated Show resolved Hide resolved
db/schema.rb Outdated Show resolved Hide resolved
db/schema.rb Outdated Show resolved Hide resolved
@zspencer zspencer force-pushed the tobias/issuing-payouts-sprout-tobias-gizmo branch from fd8fcef to 3f75e19 Compare February 13, 2024 18:20
Base automatically changed from tobias/issuing-payouts-add--system-spec-for-payout-issue to tobias/issuing-payouts February 27, 2024 01:14
@zspencer zspencer force-pushed the tobias/issuing-payouts-sprout-tobias-gizmo branch from 3ac7392 to d0472e3 Compare February 27, 2024 01:15
@zspencer zspencer force-pushed the tobias/issuing-payouts-sprout-tobias-gizmo branch from edc30a3 to 3bfafe0 Compare March 25, 2024 21:26
zspencer and others added 6 commits March 25, 2024 15:20
- #1
- zinc-collective#709

- For a #9 to leverage
  the behavior we described, we need a way to put tobias on the web.
  zinc-collective#709 are the equivalent
  of an "App" in the Convene world.

- Note: `Gizmo` and `Furniture` are equivalent. We probably should
  finish zinc-collective#1472

- The migration change makes sure that ahttps://github.com//issues/4
  is connected to #1
Next steps might include:
create "New Payout" link

Co-Authored-By: Zee <50284+zspencer@users.noreply.github.com>
Co-Authored-By: JuanCarlosTC <153764163+juancarlostc@users.noreply.github.com>
Instead, we use the mixin as a kind of
"nod-to-the-odd"
This gets us to our next interaction in the system test and prepares to
build a form with the fields necessary to issue a Payout.
@zspencer zspencer force-pushed the tobias/issuing-payouts-sprout-tobias-gizmo branch from a984ff1 to b7f902b Compare March 25, 2024 22:21
@zspencer zspencer changed the title Tobias: Sprout Tobias Gizmo Tobias: Issue a Payout via the Web Mar 25, 2024
@zspencer zspencer changed the title Tobias: Issue a Payout via the Web Tobias: Expose Trust#show with link to Payout#new Mar 25, 2024
@zspencer
Copy link
Member Author

@chloeinnvaer and/or @JuanCarlosTC - if you get a moment could you read this pull request and leave comments with observations or questions? I don't want to merge until another person has parsed the code a bit.

expose :trust, model: Trust

def show
authorize trust
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The authorize method comes from Pundit, and is how we link the code in TrustPolicy, which describes who is allowed to see or change the Trust model, to the action being taken by the user.

@@ -0,0 +1,11 @@
class Tobias
class Routes
def self.append_routes(router)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we call router.resources, we are connecting the URL path to the application.

/spaces/:space_id/rooms/:room_id, nested under the "Section" the TOBIAS is in.

So, resources :tobiases creates an entry point into our application at the /spaces/:space_id/rooms/:room_id/tobiases path. When we nest resources calls within a do...end block, like we do with router.resources :trusts this nests them within that path , a-la /spaces/:space_id/rooms/:room_id/tobiases/:tobias_id/trusts

What path do you think the line with router.resources :payouts creates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants