Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight quote when jumping to message #450

Closed
wants to merge 3 commits into from

Conversation

BlindingDark
Copy link
Contributor

This will behave more like the official Telegram client.

@BlindingDark BlindingDark marked this pull request as ready for review December 7, 2023 18:28
(when callback
(funcall callback msg-button)))
t))

(defun telega-chatbuf--remove-highlight-quote (&rest _)
"Remove highlighted quote."
(remove-overlays nil nil 'telega-chatbuf--highlight-quote t)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

@zevlg
Copy link
Owner

zevlg commented Apr 17, 2024

It is nice to have this feature, to highlight the quote, however, this implementation is a bit clumsy.
Best approach would be to to mark part of the message content to be highlighted and redisplay it. Message inserter should look at this property and apply pulse-momentary-highlight-region for that part of the message. In this approach there will be no hacks and cut&paste things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants