Fix low contrast box titles #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is there a render of the docs (or a screenshot) to see how this looks? |
|
If you click on "Details" next to the |
|
LGTM. Thanks @dstansby! |
MSanKeys963
approved these changes
Oct 1, 2024
dstansby
added a commit
to dstansby/zarr-python
that referenced
this pull request
Oct 2, 2024
MSanKeys963
pushed a commit
that referenced
this pull request
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2285. In general hard coding colours is a bad idea. I think these should just be deleted, but if we want to customize anything like this it's best to use the variables available in pydata-sphinx-theme: https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/styling.html#css-theme-variables