Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce ruff/flake8-annotations rules (ANN) #2264

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Enforce ruff/flake8-annotations rules (ANN) #2264

merged 3 commits into from
Sep 27, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Sep 27, 2024 •
edited
Loading

Enforce some ANN rules after all, but leave out lots of them, especially in tests.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@DimitriPapadopoulos
Apply ruff/flake8-annotations rule ANN204
d447d45 
ANN204 Missing return type annotation for special method `__init__`
@DimitriPapadopoulos
Apply ruff/flake8-annotations rule ANN201
2f441e1 
ANN201 Missing return type annotation for public function `basic_indices`
@DimitriPapadopoulos
Enforce ruff/flake8-annotations rules (ANN)
06daa20 
Disable lots of rules for now, especially in tests.
@jhamman jhamman merged commit 177a8c2 into zarr-developers:v3 Sep 27, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamman jhamman jhamman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @jhamman