Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace pkg_resources with packaging.version for version parsing/comparison #1450

Merged

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Jun 28, 2023

Small change to version comparison to move past failing CI related to recent deprecation of pkg_resources.

  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

Closes #1449 1449

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #1450 (6d42c84) into main (327b694) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1450   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines        14866     14866           
=========================================
  Hits         14866     14866           
Impacted Files Coverage Δ
zarr/tests/test_core.py 100.00% <100.00%> (ø)

Copy link
Contributor

@rabernat rabernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Joe!

@rabernat rabernat merged commit 2169c43 into zarr-developers:main Jun 28, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarning: pkg_resources is deprecated as an API.
2 participants