fix(async): set default concurrency to 10 tasks (#2256)

* fix(async): set default concurrency to 10 tasks * fixup
zarr-developers · Sep 26, 2024 · 4515671 · 4515671
1 parent 0e4cc7e
commit 4515671
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/zarr/core/config.py b/src/zarr/core/config.py
@@ -43,7 +43,7 @@ def reset(self) -> None:
         {
             "default_zarr_version": 3,
             "array": {"order": "C"},
-            "async": {"concurrency": None, "timeout": None},
+            "async": {"concurrency": 10, "timeout": None},
             "json_indent": 2,
             "codec_pipeline": {
                 "path": "zarr.codecs.pipeline.BatchedCodecPipeline",

diff --git a/tests/v3/test_config.py b/tests/v3/test_config.py
@@ -41,7 +41,7 @@ def test_config_defaults_set() -> None:
         {
             "default_zarr_version": 3,
             "array": {"order": "C"},
-            "async": {"concurrency": None, "timeout": None},
+            "async": {"concurrency": 10, "timeout": None},
             "json_indent": 2,
             "codec_pipeline": {
                 "path": "zarr.codecs.pipeline.BatchedCodecPipeline",
@@ -62,15 +62,15 @@ def test_config_defaults_set() -> None:
         }
     ]
     assert config.get("array.order") == "C"
-    assert config.get("async.concurrency") is None
+    assert config.get("async.concurrency") == 10
     assert config.get("async.timeout") is None
     assert config.get("codec_pipeline.batch_size") == 1
     assert config.get("json_indent") == 2
 
 
 @pytest.mark.parametrize(
     ("key", "old_val", "new_val"),
-    [("array.order", "C", "F"), ("async.concurrency", None, 10), ("json_indent", 2, 0)],
+    [("array.order", "C", "F"), ("async.concurrency", 10, 20), ("json_indent", 2, 0)],
 )
 def test_config_defaults_can_be_overridden(key: str, old_val: Any, new_val: Any) -> None:
     assert config.get(key) == old_val