Binder #6
Merged
Binder #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhamman
commented
Feb 24, 2020
| echunk = _encode_chunk( | ||
| data_chunk.tobytes(), filters=arr_meta["filters"], compressor=arr_meta["compressor"], | ||
| ) | ||
| return Response(echunk, media_type="application/octet-stream") |
There was a problem hiding this comment.
@andersy005 - I didn't mean to commit these changes here but I'll show them off anyways. This doesn't seem to work on its own but I think its a reasonable start toward making the chunk retrieval async friendly. Thoughts?
There was a problem hiding this comment.
This doesn't seem to work on its own
What are the missing pieces?
There was a problem hiding this comment.
Just that we aren't managing to retrieve keys asynchronously. If you watch the task stream, we never use two workers at the same time on the server side.
added 2 commits
February 24, 2020 11:55
andersy005
approved these changes
Feb 25, 2020
| echunk = _encode_chunk( | ||
| data_chunk.tobytes(), filters=arr_meta["filters"], compressor=arr_meta["compressor"], | ||
| ) | ||
| return Response(echunk, media_type="application/octet-stream") |
There was a problem hiding this comment.
This doesn't seem to work on its own
What are the missing pieces?
added 2 commits
February 24, 2020 16:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add's binder configs.
A simple app is deployed on launch (available at 0.0.0.0:9000).
I've updated the demo notebook to point at this app.