Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHORE: Fix PerformanceWarning in pivot combine stage #747

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ChengjieLi28
Copy link
Contributor

What do these changes do?

Fix this warning in pivot op combine stage.

performancewarning: dataframe is highly fragmented. this is usually the result of calling `frame.insert` many times, which has poor performance. consider joining all columns at once using pd.concat(axis=1) instead. to get a de-fragmented frame, use `newframe = frame.copy()`

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.7.0 milestone Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #747 (f1587de) into main (b320ca3) will decrease coverage by 27.67%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main     #747       +/-   ##
===========================================
- Coverage   77.29%   49.62%   -27.67%     
===========================================
  Files        1058     1058               
  Lines       79780    79779        -1     
  Branches    16504    12433     -4071     
===========================================
- Hits        61663    39593    -22070     
- Misses      15724    38595    +22871     
+ Partials     2393     1591      -802     
Flag Coverage Δ
unittests 49.61% <0.00%> (-27.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
python/xorbits/_mars/dataframe/base/pivot.py 23.70% <0.00%> (+0.17%) ⬆️

... and 639 files with indirect coverage changes

@XprobeBot XprobeBot modified the milestones: v0.7.0, v0.7.1 Oct 23, 2023
@XprobeBot XprobeBot modified the milestones: v0.7.1, v0.7.2 Nov 21, 2023
@XprobeBot XprobeBot modified the milestones: v0.7.2, v0.7.3 Jan 5, 2024
@XprobeBot XprobeBot modified the milestones: v0.7.3, v0.7.4 Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants