Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new "single track" modifier, fixed bug in dealing with duplicate OnPlayFinished events #58

Open
wants to merge 10 commits into
base: DEV
Choose a base branch
from

Commits on Feb 28, 2020

  1. Improved logging

    Added context information to every Serial.print call where it was missing. Previously sometimes plain numbers were logged without any hint what they could mean.
    joachimeichborn committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    45999ec View commit details
    Browse the repository at this point in the history
  2. Introduced Mode and Modifiers enums

    Introduced enums to be used instead of magic ints to increase the comprehensibility of the code
    joachimeichborn committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    9ce0f70 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2020

  1. Refactored nextTrack and previousTrack methods

    Replaced if statements with switch, removed redundancies
    joachimeichborn committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    763acc1 View commit details
    Browse the repository at this point in the history
  2. Added single track modifier

    Added a new modifier that TonUINO stops playing after the current track
    joachimeichborn committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    36832aa View commit details
    Browse the repository at this point in the history
  3. Moved check for duplicate OnPlayFinishedEvents

    The test was done after the call to the active modifier, so this was called twice. This can lead to unexpected behaviour of the modifiers. In fact the check can be moved to the Mp3Notify class. That way we also don't have to create random track numbers if the next button is pressed.
    joachimeichborn committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    8d6a615 View commit details
    Browse the repository at this point in the history
  4. Added option for a power led

    Added preprocessor directives that allow to simply activate a power led
    joachimeichborn committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    1d7b649 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2020

  1. Added shortcut to continue with the last card

    If buttons four and five are pressed long while nothing is played, the system behaves as if the non-modifier card that was used the last time was used again. So it's possible to continue a card after the system went into sleep without having to use the card.
    joachimeichborn committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    78d75ee View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2020

  1. Made some adjustments to my setup

    Set five button mode, changed button five pin, removed mp3.sleep
    joachimeichborn committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    115be7d View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2020

  1. Configuration menu
    Copy the full SHA
    e7961bb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    229e1e2 View commit details
    Browse the repository at this point in the history