Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T16176 integrate whackread into pluto #465

Open
wants to merge 74 commits into
base: master
Choose a base branch
from
Open

T16176 integrate whackread into pluto #465

wants to merge 74 commits into from

Commits on Mar 1, 2021

  1. Pass the correct arguments to _startnetkey if klips fails

    @mohicks
    mohicks committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    4cc79cc View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. Add git to the travis dependency

    @shussain
    shussain committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    69a1300 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2021

  1. Fix -Wstringop-truncation errors 

    In most cases, the strings are treated as null terminated elsewhere so
limiting to sizeof()-1 is correct.

In the case of req.ifr_name, the kernel adds null termination if the
name isn't already.

sun_path doesn't need to be null terminated, so this does limit the path
to one less than maximum.
    @mohicks
    mohicks committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    227d766 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2021

  1. Fix incorrect logic in error path 

    This caused a warning with gcc9
    @mohicks
    mohicks committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    95a1bda View commit details
    Browse the repository at this point in the history

  2. Add string of caller to suppress warning 

    In the error path this string is used to indicate the caller
    @mohicks
    mohicks committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    988f0ee View commit details
    Browse the repository at this point in the history

  3. Limit maximum memcpy to iv size 

    gcc9 issues a warning about possible overlapping areas
    @mohicks
    mohicks committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    5e95e7c View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2021

  1. Fix -Wenum-conversion warnings related to algo/hash/prf IDs

    @mohicks
    mohicks committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    23948c6 View commit details
    Browse the repository at this point in the history

  2. Disable efence banner for test ap06-algo2ikev2

    @mohicks
    mohicks committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    1d5795f View commit details
    Browse the repository at this point in the history

  3. stop tcpdump from resolving service port numbers 

    Fedora 33 starts correctly resolving the ports to service names,
so disable this with "-nn" for now.
    @mohicks
    mohicks committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    76c0eb9 View commit details
    Browse the repository at this point in the history

  4. Fix gcc-10 link errors due to duplicated symbols 

    This only affects the testing code.  I believe this is related to
-fno-common becoming the default for gcc-10.

The test code just needed a bit of cleanup to stop duplicating symbols
that are part of libpluto.
    @mohicks
    mohicks committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    101b01b View commit details
    Browse the repository at this point in the history

  5. wo#11419: Disable efence in tests to prevent segfault 

    A few tests segfault on ubuntu 20.04 due to a glibc/efence
incompatibility when calling getaddrinfo().  Disable efence
for these tests to avoid the issue.
    @mohicks
    mohicks committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    23d3edf View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2021

  1. when looking for a mask for ::/0, bitstomask6 routine gets it wrong

    @mcr @shussain
    mcr authored and shussain committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    e111894 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. include cbor2diag for unit test cases

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    76e2d93 View commit details
    Browse the repository at this point in the history

  2. added cborseq2diag and output

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    8b0998f View commit details
    Browse the repository at this point in the history

  3. initial setup for wo01-msgstop unit test case, using QCBOR

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    30fd08a View commit details
    Browse the repository at this point in the history

  4. added wo02 test, and sorted wo01 as shutdown

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    9f8aa06 View commit details
    Browse the repository at this point in the history

  5. added wo03, with options for pluto debug

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    bb63557 View commit details
    Browse the repository at this point in the history

  6. updated test cases for revised CDDL

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    5880c8d View commit details
    Browse the repository at this point in the history

  7. change encoding to be map of maps

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    d027eff View commit details
    Browse the repository at this point in the history

  8. added wo04 for connection

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    a5a9cc1 View commit details
    Browse the repository at this point in the history

  9. encode the left/right now

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    7577276 View commit details
    Browse the repository at this point in the history

  10. complete most of the QCBOR encoding for the whack message

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    6573d24 View commit details
    Browse the repository at this point in the history

  11. change right.host_addr to distinguish left/right

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    611b0a7 View commit details
    Browse the repository at this point in the history

  12. updated qcbor

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    5e240a2 View commit details
    Browse the repository at this point in the history

  13. QCBOR based encoder and decoder, probably almost feature complete exc… 

    …ept for RSA key values
    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    d66864a View commit details
    Browse the repository at this point in the history

  14. initialize size of sendbuf before encoding

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    2a5d71d View commit details
    Browse the repository at this point in the history

  15. log magic bytes in order, log size, and pass entire buffer to decoder

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    f27112c View commit details
    Browse the repository at this point in the history

  16. examine CBOR output from examples

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    c77bf9d View commit details
    Browse the repository at this point in the history

  17. added conn policy and lifetimes to connection

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    7db4c2f View commit details
    Browse the repository at this point in the history

  18. log size of whack message clearly

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    5efaab0 View commit details
    Browse the repository at this point in the history

  19. turn off detail of readwrite test for now

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    3341a84 View commit details
    Browse the repository at this point in the history

  20. add keys properly, remove some cruft and fix bug where label key was … 

    …used rather than value
    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    4fcd6c0 View commit details
    Browse the repository at this point in the history

  21. added step2X to call READWRITE to validate resulting CBOR

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    3b1c825 View commit details
    Browse the repository at this point in the history

  22. add missing int/bool types from whack_end

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    f531dd1 View commit details
    Browse the repository at this point in the history

  23. use newly created cborseq2pretty

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    b23474f View commit details
    Browse the repository at this point in the history

  24. added cborseq2pretty to utils until it gets released

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    1021584 View commit details
    Browse the repository at this point in the history

  25. added cbor pretty version of moon.conf, host-host

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    10fa939 View commit details
    Browse the repository at this point in the history

  26. remove duplicate processing of whack_status

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    547cd9a View commit details
    Browse the repository at this point in the history

  27. whack status request can be alone

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    2016dbb View commit details
    Browse the repository at this point in the history

  28. enable whack library test 05

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    ce9f55a View commit details
    Browse the repository at this point in the history

  29. encode more options

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    b242545 View commit details
    Browse the repository at this point in the history

  30. added cborseq2pretty check on connection output

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    b7c34b5 View commit details
    Browse the repository at this point in the history

  31. updated wo05 test to use cborseq2pretty, and to re-initialize size of… 

    … buffer on second output
    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    7776a6e View commit details
    Browse the repository at this point in the history

  32. it seems that some public keys were not loaded correctly before!

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    631eaee View commit details
    Browse the repository at this point in the history

  33. change whack_cbor_decode_msg to have a length as a value/result param… 

    …eter
    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    6c9baa6 View commit details
    Browse the repository at this point in the history

  34. updated pol01 with cbor whack changes

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    595e2b6 View commit details
    Browse the repository at this point in the history

  35. collect host_addr definitions in one place

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    8b83355 View commit details
    Browse the repository at this point in the history

  36. additional keys now properly loaded

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    47a77cc View commit details
    Browse the repository at this point in the history

  37. arrange to free strings that whack_cbor_decode_msg allocates

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    fea8b87 View commit details
    Browse the repository at this point in the history

  38. when reading saved whack files, just find out how big the file is, an… 

    …d suck it all in
    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    d72241c View commit details
    Browse the repository at this point in the history

  39. clear out the whackmessage in the read routine, set ip addresses to u… 

    …nspec
    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    783021c View commit details
    Browse the repository at this point in the history

  40. updates to test cases to deal with subtle changes due to updated libw… 

    …hack
    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    08f707f View commit details
    Browse the repository at this point in the history

  41. added WHACK_OPT_END_ADDR_FAMILY attribute

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    fd60475 View commit details
    Browse the repository at this point in the history

  42. do better logging for address inconsistency, and avoid comparing left… 

    …/right clients if there are no clients
    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    95c98ef View commit details
    Browse the repository at this point in the history

  43. changes to test case to deal with additions made to libwhack for miss… 

    …ing attributes
    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    c66d966 View commit details
    Browse the repository at this point in the history

  44. do not initialize the nexthop, and in the address consistency check, … 

    …skip checking it if was not set
    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    fedb4c2 View commit details
    Browse the repository at this point in the history

  45. updated prio, due to initialization of host_addr

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    2eee5b1 View commit details
    Browse the repository at this point in the history

  46. split whacklib.c into two files so that unnecessary code is not linke… 

    …d in. Also easier to maintain
    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    195ec55 View commit details
    Browse the repository at this point in the history

  47. call git submodule at each version

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    956b172 View commit details
    Browse the repository at this point in the history

  48. updated QCBOR to one with warnings patched

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    6e476c0 View commit details
    Browse the repository at this point in the history

  49. make sbin directory in which to put tcpdump

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    448f7c4 View commit details
    Browse the repository at this point in the history

  50. fix qcbor submodule link, to warningless code

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    9dd8787 View commit details
    Browse the repository at this point in the history

  51. added unit test to validate encoding of --initiate

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    2329214 View commit details
    Browse the repository at this point in the history

  52. test case for calling initiate

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    bcea05f View commit details
    Browse the repository at this point in the history

  53. change conn name to mytunnel

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    d6909b6 View commit details
    Browse the repository at this point in the history

  54. setup recorded file with --initiate at the end

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    0ea1087 View commit details
    Browse the repository at this point in the history

  55. enable passert() with -DEBUG!

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    ef756e6 View commit details
    Browse the repository at this point in the history

  56. set missing whack_* variables when reading, and validate whack_initia… 

    …te in new test case
    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    cadefc2 View commit details
    Browse the repository at this point in the history

  57. log when the connection is inititiated via whack

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    2d00a6e View commit details
    Browse the repository at this point in the history

  58. move and rename whackread, because it is only ever used inside pluto,… 

    … and unit tests
    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    0319495 View commit details
    Browse the repository at this point in the history

  59. return intelligent diagnostic message when decoding wrong values, upd… 

    …ate QCBOR
    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    781da27 View commit details
    Browse the repository at this point in the history

  60. rip unused whackpacker content out of file

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    f803591 View commit details
    Browse the repository at this point in the history

  61. if QCBOR is not compiled with consistent -DCONFIG options, resulting … 

    …in item.label being in different place

for plutoctrl_cbor.c than for compiled QCBOR library in libwhack.
    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    a89b73f View commit details
    Browse the repository at this point in the history

  62. updates to test cases based upon CBORSEQ tag type

    @mcr
    mcr committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    20fd1e1 View commit details
    Browse the repository at this point in the history