Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run build and test on master to normalize workflows #56

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

astone123
Copy link
Collaborator

@astone123 astone123 commented Oct 9, 2023

Right now we have two workflows:

  • Build and Test
  • Deploy

The Deploy workflow does some stuff that we already do in Build and Test. This PR makes it so that all of the jobs are in one workflow, and deploy only runs after building and testing are successful, and only if the branch is master, otherwise we skip the deploy step

This way we're doing the same build and test on master that we are in PRs. Less duplication

@astone123 astone123 self-assigned this Oct 9, 2023
@wweitzel
Copy link
Owner

@astone123 Do we need to add a

- uses: actions/download-artifact@v3
        with:
          name: build

to the deploy workflow? It needs that folder for the Sync files to S3 step

@astone123
Copy link
Collaborator Author

I think it's easier to do it like this with them all in one workflow. Then you get a nice diagram of the flow
Screenshot 2023-10-22 at 6 09 49 PM

Github actions doesn't really have a built-in way to upload and download artifacts across different workflows as far as I can tell

@astone123
Copy link
Collaborator Author

I think re-naming the workflow improves the PR check view

Screenshot 2023-10-22 at 6 49 25 PM

Copy link
Owner

@wweitzel wweitzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wweitzel wweitzel merged commit 0e5eb2e into master Oct 27, 2023
4 checks passed
@wweitzel wweitzel deleted the normalize-workflow branch October 27, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants