Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nullability Annotations to Java Classes] Add Missing Nullability Annotations to TaxonomyXMLRPCClient (safe) #2866

Merged
merged 13 commits into from
Oct 11, 2023
Merged

[Nullability Annotations to Java Classes] Add Missing Nullability Annotations to TaxonomyXMLRPCClient (safe) #2866

merged 13 commits into from
Oct 11, 2023

Commits on Oct 9, 2023

  1. Refactor: Reformat taxonomy xmlrpc client

    @ParaskP7
    ParaskP7 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    ccbed76 View commit details
    Browse the repository at this point in the history

  2. Analysis: Create missing switch cases for taxonomy xmlrpc client errors 

    Error: "'switch' statement on enum type
'org.wordpress.android.fluxc.network.BaseRequest.GenericErrorType'
misses cases: 'TIMEOUT', 'NO_CONNECTION', 'NETWORK_ERROR', 'NOT_FOUND',
'CENSORED', 'SERVER_ERROR', 'INVALID_SSL_CERTIFICATE',
'HTTP_AUTH_ERROR', 'INVALID_RESPONSE', 'NOT_AUTHENTICATED',
'PARSE_ERROR' and 'UNKNOWN'"
    @ParaskP7
    ParaskP7 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    345c8a8 View commit details
    Browse the repository at this point in the history

  3. Refactor: Replace anonymous classes with lambda

    @ParaskP7
    ParaskP7 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    fc6f0d6 View commit details
    Browse the repository at this point in the history

  4. Analysis: Remove unnecessary is response null check 

    Warning: "Condition 'response != null' covered by subsequent condition
'response instanceof Map'"
    @ParaskP7
    ParaskP7 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    411634a View commit details
    Browse the repository at this point in the history

  5. Analysis: Guard usages of terms response to terms model method

    @ParaskP7
    ParaskP7 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    efd5eaa View commit details
    Browse the repository at this point in the history

  6. Analysis: Replace value of with long parse long for string reponse 

    Warning: "Redundant boxing, 'Long.parseLong()' call can be used instead"
    @ParaskP7
    ParaskP7 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    173df0e View commit details
    Browse the repository at this point in the history

  7. Analysis: Add missing n-a to fetch term on taxonomy xmlrpc client 

    FYI: 'n-a' stands for 'nullability annotations'.
    @ParaskP7
    ParaskP7 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    57d0108 View commit details
    Browse the repository at this point in the history

  8. Analysis: Add missing n-a to fetch terms on taxonomy xmlrpc client 

    FYI: 'n-a' stands for 'nullability annotations'.
    @ParaskP7
    ParaskP7 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    1a74d6e View commit details
    Browse the repository at this point in the history

  9. Analysis: Add missing n-a to push term on taxonomy xmlrpc client 

    FYI: 'n-a' stands for 'nullability annotations'.
    @ParaskP7
    ParaskP7 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    b71a975 View commit details
    Browse the repository at this point in the history

  10. Analysis: Add missing n-a to delete term on taxonomy xmlrpc client 

    FYI: 'n-a' stands for 'nullability annotations'.
    @ParaskP7
    ParaskP7 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    59d6eab View commit details
    Browse the repository at this point in the history

  11. Analysis: Add missing n-a to terms response to terms model method 

    FYI: 'n-a' stands for 'nullability annotations'.
    @ParaskP7
    ParaskP7 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    19a3870 View commit details
    Browse the repository at this point in the history

  12. Analysis: Add missing n-a to term response object to term model method 

    FYI: 'n-a' stands for 'nullability annotations'.
    @ParaskP7
    ParaskP7 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    c5fc4ff View commit details
    Browse the repository at this point in the history

  13. Analysis: Add missing n-a to term model to content struct method 

    FYI: 'n-a' stands for 'nullability annotations'.
    @ParaskP7
    ParaskP7 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    e17f655 View commit details
    Browse the repository at this point in the history