-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make AccessKey the key entrypoint for public apis #285
Conversation
Codecov Report
@@ Coverage Diff @@
## main #285 +/- ##
==========================================
+ Coverage 60.47% 61.47% +0.99%
==========================================
Files 40 40
Lines 2763 2707 -56
Branches 690 679 -11
==========================================
- Hits 1671 1664 -7
+ Misses 622 571 -51
- Partials 470 472 +2
|
Same with this PR, I'd prefer this to be marked as "feat" instead of "fix". |
This needs conflicts resolved. Then I'd give it a look, we can merge and finally release :) |
d3f5b4c
to
95ddaf7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
I like these!
We learned that some things are useful on its own (SharePayload), rename them and sprinkle them along the API more.
We learned that you shouldn't create seeded keys and directories themselves, but instead seed an asymmetric keypair. Thus making a bunch of RevisionRef
stuff obsolete.
We'll continue to learn more about exactly how we should best structure stuff.
I'm pretty confident we're continually improving :)
I'd love to have this merged, so I can do a final rebase of #247 and finally have a review & merge on that too.
Co-authored-by: Philipp Krüger <philipp.krueger1@gmail.com> Signed-off-by: Stephen Akinyemi <appcypher@outlook.com>
This PR brings the multiple ways of generating key materials for accessing nodes in a filesystem under a single type. The
AccessKey
now becomes the only way of accessing the nodes in a file system. It is important to note that the Snapshot aspect of AccessKey is not at all functional right now.This PR implements the following features
Test plan (required)
Testing
scripts/rs-wnfs test
Closing issues
Fixes #249