add support for conformsTo (#100) #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkralidis
requested review from
gaubert,
amilan17,
solson-nws,
josusky,
efucile,
davidpodeur,
jsieland,
antje-s,
Amienshxq and
McDonald-Ian
tomkralidis
force-pushed
the
issue-100
branch
from
35d6c2c
to
5927135
Compare
antje-s
reviewed
Mar 8, 2024
There was a problem hiding this comment.
Only one question:
why not using
"http://wis.wmo.int/spec/wnm/1/conf/core" for example?
There was a problem hiding this comment.
The JSON schema is generated from the YAML schema. Because the YAML schema references conformsTo from the OGC definitions, the examples from the OGC definitions are what are pulled in/integrated. I've made the change in this PR but we need to be aware when regenerating the JSON schema.
There was a problem hiding this comment.
...thank you for the explanation
antje-s
approved these changes
Mar 8, 2024
antje-s
approved these changes
Mar 8, 2024
amilan17
approved these changes
Mar 25, 2024
|
TT-WISMD 2024-03-25:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100