Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture of external logs and general improvements #35

Merged
merged 7 commits into from
Sep 14, 2023
Merged

Conversation

RoryPTB
Copy link
Contributor

@RoryPTB RoryPTB commented Sep 12, 2023

Changes made:

  • Added support for zero precipitation when the precipitation indicator iR = 3. That is, when iR = 3, absent precipitation groups represent zero preciptation, not missing data.
  • NIL reports are no longer written as an empty BUFR and the user is informed of this through a warning.
  • Section 3 and section 4 mappings were not being updated correctly which caused the incorrect error Missing station height. This has been fixed.
  • Test data has been updated, most notably the wis2box-data now has a barometer_height column to meet the current requirements of synop2bufr.
  • Pymetdecoder and csv2bufr logs are now captured and stored appropriately in warning and error arrays which can be accessed in the webapp.
  • Valid min and max values have been implemented directly into the 307080 and 307096 mapping files so that out of range errors are handled before ecCodes and are more informative for the user. Many of these valid ranges have been taken from the WMO Guide to Instruments and Methods.
  • Added a verification that, if both reported, the dewpoint temperature is less than or equal to the air temperature.
  • Unit tests have been added for the two quality control steps above.

@david-i-berry david-i-berry merged commit 5193dbe into main Sep 14, 2023
6 checks passed
@david-i-berry david-i-berry deleted the rory-logging branch September 14, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants