Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTA-1289 adding new mta cli commands: Analyze and Transform #792

Merged
merged 13 commits into from
Jan 30, 2024

Conversation

emarcusRH
Copy link
Contributor

@emarcusRH emarcusRH commented Dec 21, 2023

https://issues.redhat.com/browse/MTA-1289

  • Adding 2 new modules to the CLI Guide:

    • Analyze command: cli-guide/topics/mta-cli-analyze.adoc

    • Transform command: cli-guide/topics/mta-cli-transform.adoc

  • Created new attribute for the CLI command name, added it to the templates/document-attributes.adoc file:
    mta-cli

Copy link

netlify bot commented Dec 21, 2023

Deploy Preview for windup-documentation ready!

Name Link
🔨 Latest commit 1b3cbf6
🔍 Latest deploy log https://app.netlify.com/sites/windup-documentation/deploys/65aea3f884b29f0008eebf1a
😎 Deploy Preview https://deploy-preview-792--windup-documentation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@emarcusRH emarcusRH changed the title MTA-1289 adding new mta cli command modules Analyze and Transform MTA-1289 adding new mta cli commands: Analyze and Transform Dec 28, 2023
docs/topics/mta-cli-analyze.adoc Outdated Show resolved Hide resolved
docs/topics/mta-cli-analyze.adoc Outdated Show resolved Hide resolved
docs/topics/mta-cli-analyze.adoc Outdated Show resolved Hide resolved
docs/topics/mta-cli-analyze.adoc Outdated Show resolved Hide resolved
docs/topics/mta-cli-analyze.adoc Show resolved Hide resolved
docs/topics/mta-cli-transform.adoc Outdated Show resolved Hide resolved
docs/topics/mta-cli-transform.adoc Outdated Show resolved Hide resolved
docs/topics/mta-cli-transform.adoc Outdated Show resolved Hide resolved
@CarmiWisemon
Copy link
Contributor

A few small comments.
LGTM

Copy link

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emarcusRH
Copy link
Contributor Author

emarcusRH commented Jan 15, 2024

LGTM

Updated the Analyze and Transform command flag options following new Dev updates:
konveyor/kantra#143
konveyor/kantra#141

@dymurray please review the updated mta-cli-analyze.adoc and mta-cli-transform.adoc

Copy link

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought, but otherwise looks to me once @jmle fix is in

docs/topics/mta-cli-transform.adoc Show resolved Hide resolved
@emarcusRH emarcusRH merged commit b1422c1 into windup:main Jan 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants