Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added validuntil option #222

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added validuntil option #222

wants to merge 1 commit into from

Conversation

slinso
Copy link

@slinso slinso commented Mar 4, 2020

I needed some kind of TTL for the URL, so it is possible to expire public URLs to an image, so passing image URLs around and requesting the image is not possible an infinite time.
My simple approach was to add a validUntil Parameter to the Options

vu{date:20060102}

I added the option to the signature so it is not possible to change the validity of the URL.
For my use-case it is ok if images are only valid a single day. otherwise you would have to put some thought into URL generation in your own app to always use the same date, so browser caching would be possible longer than a single day.

What do you think?

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@slinso
Copy link
Author

slinso commented Mar 4, 2020

@googlebot I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #222 into master will decrease coverage by 1.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
- Coverage   89.16%   87.73%   -1.44%     
==========================================
  Files           6        6              
  Lines         674      685      +11     
==========================================
  Hits          601      601              
- Misses         50       59       +9     
- Partials       23       25       +2     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00652fd...12f2d48. Read the comment docs.

@willnorris willnorris changed the base branch from master to main June 22, 2020 17:00
@AnTheMaker
Copy link

Hi there! This sounds like a really useful addition! Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants