Memory usage #4
Open
Memory usage #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You do not need to create new translate function instance on each relativeDate call. Constants can also be created once.
Now it should build and pass tests
I have teached this lesson. Test everything locally. If this build fail - I would download repo and fix everything locally.
|
I love your final commit message! These changes seem fine to me. I would prefer that the Out of curiosity: do you have any benchmarks comparing this library before and after your change? |
|
I just want to test this out on a couple of projects before I merge. I've been extra-cautious about releasing updates to this package since it became a dependency of npm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use your library in high speed env, so I am reviewing all foreign code.
You do not need to create new translate function instance on each relativeDate call.
Constants can also be created once.