[GAL-364] Fix installing features pack into a sym-link directory #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfdenise
reviewed
Aug 29, 2024
| try { | ||
| Files.createDirectories(target); | ||
| } catch (FileAlreadyExistsException e) { | ||
| // FileAlreadyExistsException happen if the target path already exists and it's not directly (symbolic link or regular file) |
There was a problem hiding this comment.
I don't fully follow the content of the comment. The sentence seems incomplete. From the Javadoc, we can read: "if dir exists but is not a directory". if yo ucould clarify in the comment. Thank-you.
jfdenise
reviewed
Aug 29, 2024
| // FileAlreadyExistsException happen if the target path already exists and it's not directly (symbolic link or regular file) | ||
| // this exception can be ignored if it's symbolic link and if real path of the symbolic link is directory. | ||
| if (!Files.isDirectory(target)) { | ||
| throw new IOException("Unable to copy file(s) from source path [" + source + "] to target path [" + target + "] because the target path is not directory (regular file or symbolic link where real path is not directory).", e); |
There was a problem hiding this comment.
I don't fully follow the content of the Exception. Should it be: " because the target path is not a directory (it is a regular file or a symbolic link where the target path is not a directory)"?
jfdenise
reviewed
Aug 29, 2024
| try { | ||
| Files.createDirectories(target.getParent()); | ||
| } catch (FileAlreadyExistsException e) { | ||
| // FileAlreadyExistsException happen if the target path already exists and it's not directly (symbolic link or regular file) |
There was a problem hiding this comment.
Same as previous comments.
parents are symlinks
|
@jfdenise I found one more corner case that previous fix was not covering and changed the logic to evaluate the links in the path before copy operation instead of catching the exception |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/GAL-364