Resolves#236 Update the namespace detection for the root namespace to support stability level qualifiers. #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI this is the WildFly Core PR that exposed this issue: |
darranl
force-pushed
the
Issue#236
branch
2 times, most recently
from
413c216
to
f82132c
Compare
… support stability level qualifiers.
simkam
approved these changes
Sep 6, 2024
jbliznak
reviewed
Sep 6, 2024
core/src/main/java/org/wildfly/extras/creaper/core/offline/OfflineServerVersion.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/wildfly/extras/creaper/core/offline/OfflineServerVersion.java
Outdated
Show resolved
Hide resolved
| @@ -296,6 +317,23 @@ public void discoverHostXml_wfly28() throws IOException { | |||
| test(ServerVersion.VERSION_21_0_0, HOST_XML, WFLY28_ROOT, EAP7_LOGGING, EAP8_EE); | |||
| } | |||
|
|
|||
| @Test | |||
| public void discoverHostXml_wfly34_community() throws IOException { | |||
| test(ServerVersion.VERSION_20_0_0, HOST_XML, COMMUNITY, WFLY27_ROOT, EAP7_LOGGING, EAP8_EE); | |||
There was a problem hiding this comment.
Just note: the version of root element does not correspond to the test target but we will be updating supported WF versions in next PR so we might fix it there later.
There was a problem hiding this comment.
+1 there is no guarantee that the schema version will even be updated on a major WildFly version so many WildFly versions will share the same schema version even if they have distinct model versions.
…lineServerVersion.java Co-authored-by: jbliznak <jbliznak@users.noreply.github.com>
…lineServerVersion.java Co-authored-by: jbliznak <jbliznak@users.noreply.github.com>
|
@jbliznak Thank you for the suggestions, I committed them to the topic branch. |
jbliznak
approved these changes
Sep 6, 2024
|
Thank You! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the regular expression I did first try an extra segment of lowercase alpha characters followed by the colon but that is where I saw we had an overlap with the namespaces of some of our early subsystems so instead specify the known qualifiers.
Although they are not all in use at the moment and which one is present by default will change over time I added tests for all stability levels to check they can all be parsed correctly.