Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure font settings for preview #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

estum
Copy link

@estum estum commented Dec 27, 2016

This PR changes preview type to kUITypeHTML and adds keys to user defaults: fontFamily, fontSize, lineHeight.
It solves issue #31

Configuration examples:

$ defaults write com.whomwah.quicklookstephen fontFamily "InputMono-Regular"
$ defaults write com.whomwah.quicklookstephen fontSize "13px"
$ defaults write com.whomwah.quicklookstephen lineHeight "21px"

Solving issue whomwah#31
Added keys to defaults: fontFamily, fontSize, lineHeight.
Changing preview type to kUITypeHTML.
@tsdorsey
Copy link
Collaborator

Thanks @estum. Will merge this soon.

@buggymcbugfix
Copy link

Any chance this will be merged soon? Cheers!

@tessus
Copy link
Contributor

tessus commented Jan 11, 2019

@estum your code compiles, but unfortunately the plugin stops working.

This is the error:

Error reading file at file:///path/to/file/README
The specified text encoding isn’t applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants