Show output of msconvert.exe on error

white-lab · Jan 28, 2019 · e31c423 · e31c423
1 parent e30202a
commit e31c423
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/ChangeLog.md b/ChangeLog.md
@@ -1,5 +1,11 @@
 # Change Log
 
+## 0.13.9 (2019-01-28)
+
+Bug fixes
+
+  - Show output of msconvert.exe on error.
+
 ## 0.13.8 (2019-01-25)
 
 Bug fixes

diff --git a/pycamv/proteowizard.py b/pycamv/proteowizard.py
@@ -218,7 +218,15 @@ def raw_to_mzml(raw_path, out_dir, scans=None, mz_window=None):
         "-c", config_path,
     ]
 
-    out = subprocess.check_output(cmd)
+    try:
+        out = subprocess.check_output(
+            cmd,
+            stderr=subprocess.STDOUT,
+        )
+    except subprocess.CalledProcessError as err:
+        LOGGER.error("Error Running msconvert:\n{}".format(err.output))
+        raise
+
     encoding = sys.stdout.encoding or "utf-8"
     LOGGER.debug(out.decode(encoding))
 

diff --git a/pycamv/version.py b/pycamv/version.py
@@ -1,4 +1,4 @@
-__version__ = "0.13.8"
+__version__ = "0.13.9"
 """
 PyCAMVerter Version.
 """