Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: psr-4 and psr-12 #45

Merged
merged 2 commits into from
Aug 14, 2024
Merged

feat: psr-4 and psr-12 #45

merged 2 commits into from
Aug 14, 2024

Conversation

tiller1010
Copy link
Member

https://werkbotstudios.teamwork.com/app/tasks/33908188

Summary

Testing Steps

Git Flow

  • DO NOT delete "release/*" or "hotfix/*" branches after merging a PR. These are used to publish the next release, and they are deleted automatically.
  • "Squash and merge" is good on "feature/*" into "develop"
  • "Create a merge commit" is good on "release/*" or "hotfix/*" into "master"

Copy link
Member

@aletail aletail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but while running the update doctum.config.php I did get a parse error...but no extra information with it. It still built the docs

fix: restored ss5 compatible queued jobs

fix: restored ss5 compatibility

fix: removed duplicate class import

fix: imported new searchindex full class name

fix: imported new tntsearchhelper full class name
@tiller1010
Copy link
Member Author

This looks good, but while running the update doctum.config.php I did get a parse error...but no extra information with it. It still built the docs

Adding -vvv to the end of the command uses the highest verbosity, which gave...

ERROR: The method "SiteSearchFormResults" has "3" @param tags but only "2" where expected. on "Werkbot\Search\SearchControllerExtension::SiteSearchFormResults" in C:\Users\tille\Desktop\modules\werkbot-search/src\SearchControllerExtension.php:73

Copy link
Member

@aletail aletail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@tiller1010 tiller1010 merged commit d18d125 into develop Aug 14, 2024
1 check passed
@tiller1010 tiller1010 deleted the feature/psr-4 branch August 14, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants