Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/1.2.3/dev build search fix #33

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Release/1.2.3/dev build search fix #33

merged 4 commits into from
Dec 21, 2023

Conversation

tiller1010
Copy link
Member

@tiller1010 tiller1010 commented Dec 21, 2023 •
edited by aletail
Loading

Summary

Release PR for dev/build search fix and getSearchResults method

Testing Steps

  • (optional) test again
  • confirm the release draft looks good

Git Flow

  • DO NOT delete "release/*" or "hotfix/*" branches after merging a PR. These are used to publish the next release, and they are deleted automatically.
  • "Squash and merge" is good on "feature/*" into "develop"
  • "Create a merge commit" is good on "release/*" or "hotfix/*" into "main"

aletail
aletail approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@aletail aletail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@tiller1010 tiller1010 merged commit 02d6a93 into main Dec 21, 2023
3 checks passed
@github-actions github-actions bot deleted the release/1.2.3/dev-build-search-fix branch December 21, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aletail aletail aletail approved these changes

Assignees
No one assigned
Labels
patch
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiller1010 @aletail