Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added check for search key, updated workflow files #29

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix: added check for search key, updated workflow files #29

merged 1 commit into from
Dec 11, 2023

Conversation

tiller1010
Copy link
Member

@tiller1010 tiller1010 commented Dec 8, 2023 •
edited by aletail
Loading

https://werkbot.sentry.io/issues/4289566830/events/1492c5c3d279427c8be72f5b05a46334/?project=5403165

Summary

Added check for a Search key

Testing Steps

  • go to /home/SiteSearchForm (get request)
  • confirm no error shows

Concern

Git Flow

  • DO NOT delete "release/*" or "hotfix/*" branches after merging a PR. These are used to publish the next release, and they are deleted automatically.
  • "Squash and merge" is good on "feature/*" into "develop"
  • "Create a merge commit" is good on "release/*" or "hotfix/*" into "master"

aletail
aletail approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@aletail aletail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked great!

@tiller1010 tiller1010 merged commit 959d602 into main Dec 11, 2023
3 checks passed
@github-actions github-actions bot deleted the hotfix/1.2.2/search-key-check branch December 11, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aletail aletail aletail approved these changes

Assignees
No one assigned
Labels
patch
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiller1010 @aletail