Added a script: Boston_CityHallElectricity #41

shivam7569 · 2019-10-01T12:49:09Z

I have added a new script of Boston_CityHall_Electricity dataset as per the instructions.

henrykironde

@andy6975 thanks for this PR. This is a good start.

When installing could you use pip install . -U / pip install . --upgrade and not pip install retriever.
It is also good practice to keep your current working branches upgraded to master.

henrykironde · 2019-10-01T14:38:46Z

scripts/boston_cityhall_electricity.json

@@ -0,0 +1,35 @@
+{
+    "citation": "FILL",
+    "description": "FILL",


We have to fill in the values that have FILL
Give a good description of the dataset

"description": "Electric power load at City Hall (1 City Hall Square) measured every 15 minutes."

Landing page for the dataset

"homepage": "https://data.boston.gov/dataset/city-hall-electricity-usage",

The link used to download the csv file

"url": "https://data.boston.gov/dataset/1b894599-21ff-478f-937d-653954977951/resource/f123e65d-dc0e-4c83-9348-ed46fec498c0/download/tmpvi7_mwih.csv"

"licenses": [ { ... "name": "PDDL"

henrykironde · 2019-10-01T14:43:13Z

scripts/boston_cityhall_electricity.json

+            "name": "FILL"
+        }
+    ],
+    "name": "FILL",


The name of the dataset. This is usually the same as the file name with no extension and _replaced with - i.e boston-cityhall-electricity

henrykironde · 2019-10-01T14:47:05Z

scripts/boston_cityhall_electricity.json

+    "resources": [
+        {
+            "dialect": {},
+            "name": "tmp7mv7ycav",


This name is that table name, we can give our table a better name. For example we could say consumption or usage, etc

Also add "path":"tmp7mv7ycav.csv" in the resources. You can put that below 'name'

henrykironde · 2019-10-01T14:58:48Z

Also refer: https://retriever.readthedocs.io/en/latest/recipes.html

shivam7569 · 2019-10-01T19:13:20Z

I have added the required information in the script. Sorry for multiple PRs, I realized it later that once you push from a branch on your forked repo to original repo, then from next time it automatically does that to the original repo. I hope I'm not being a big trouble. Thanks!

henrykironde · 2019-10-01T19:15:42Z

scripts/boston_cityhall_elec.json

@@ -0,0 +1,36 @@
+{
+    "citation": "Department of Innovation and Technology",


No citation in the data so we can leave that as, "citation": ""

henrykironde · 2019-10-01T19:18:55Z

scripts/boston_cityhall_elec.json

+            "name": "Open Data Commons Public Domain Dedication and License (PDDL)"
+        }
+    ],
+    "name": "boston-cityhall-electricity-usage",


If you choose name boston-cityhall-electricity-usage
then the file should be named as boston_cityhall_electricity_usage.json

I have corrected the name of the file.

Note the _ vs - in file name

henrykironde · 2019-10-01T19:20:10Z

scripts/boston_cityhall_elec.json

+    "citation": "Department of Innovation and Technology",
+    "description": "Electric power load at City Hall (1 City Hall Square) measured every 15 minutes. And it is continously updated.",
+    "homepage": "https://data.boston.gov/dataset/city-hall-electricity-usage",
+    "keywords": ["City Hall", "Demand", "Electricity", "Energy", "Load", "Meter", "Power"],


"Electricity", "Energy", "Boston" could be enough.

henrykironde · 2019-10-01T19:29:53Z

scripts/boston_cityhall_elec.json

+            "name": "Open Data Commons Public Domain Dedication and License (PDDL)"
+        }
+    ],
+    "name": "boston-cityhall-electricity-usage",


Note the _ vs - in file name

henrykironde · 2019-10-01T19:31:39Z

scripts/boston-cityhall-electricity-usage.json

+    ],
+    "retriever": "True",
+    "retriever_minimum_version": "2.1.0",
+    "title": "Boston-CityHall-Energy-Consumption",


Boston City Hall Electricity Usage

henrykironde · 2019-10-01T19:32:51Z

@andy6975 Sorry lets keep the keywords as you had them before

shivam7569 · 2019-10-01T19:44:39Z

The name has been corrected. The tags have been left as they were before,

henrykironde · 2019-10-01T19:44:45Z

@andy6975, this all looks good.
Now we need to change the dialect to add "," since the file is comma separated

            "dialect": {
                "delimiter": ","
            },

Also add a blank line after
https://github.com/weecology/retriever-recipes/pull/41/files#diff-164cd784c96a3b9261cc2896e039c194R36

Once you are done Run, python version.py with in the repo to update the version.txt file and push it to

shivam7569 · 2019-10-01T20:29:39Z

The following changes have been made:

The delimiter has been added.
A new line at the end of the script.
version.txt file has been updated

henrykironde · 2019-10-01T20:47:22Z

You missed this. Boston-CityHall-Energy-Consumption > Boston City Hall Energy Consumption
After run retriever reset scripts this will delete the scripts in the ~/.retriever/scripts directory making your environment clean.

While you are still in this same repo, run retriever update and then python version.py
Since you are adding one script the version file will have only one line of change added

shivam7569 · 2019-10-01T21:20:25Z

I have changed the title. Sorry I didn't notice it before.
I ran the commands you ask me to and I read about them in the documentation too and this helped me understand more about the working of this project.

henrykironde · 2019-10-01T23:09:38Z

The version file is still missing something,
Let us run pip install . -U in both the retriever and retriever-recipes repos.
Do a clean up of scripts retriever reset scripts, retriever update and
Then run python version.py in the retriever-recipes.
This may clean the version file.

shivam7569 · 2019-10-02T05:47:50Z

Hi, what change are we exactly looking for the version.txt file to show? As I read it, I think it's the file which has the names of all the available datasets and since we've added the boston electricity dataset, it should also has the name of this dataset, right? But I think you mean to see that difference in retriever repo too and not just retriever-recipes repo, right?

shivam7569 added 12 commits October 1, 2019 06:54

Added a script

b29f6d0

Deleted a folder

783c70d

Added a new script

fc8b512

Filled the script with required information

8e86162

Added some information

2b23781

Added the information required.

82e0582

Corrected some information

f46f2c3

Corrected the name of the file.

02d4c2a

Corrected the name

b51b09f

Changed the delimiter

0c07c51

Updated the version.txt file

3c82a01

Changed the title

81fa380

henrykironde reviewed Oct 1, 2019

View reviewed changes

Base automatically changed from master to main February 11, 2021 09:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added a script: Boston_CityHallElectricity #41

Added a script: Boston_CityHallElectricity #41

shivam7569 commented Oct 1, 2019

henrykironde left a comment

henrykironde Oct 1, 2019

henrykironde Oct 1, 2019

henrykironde Oct 1, 2019

henrykironde Oct 1, 2019

henrykironde commented Oct 1, 2019

shivam7569 commented Oct 1, 2019

henrykironde Oct 1, 2019

henrykironde Oct 1, 2019

shivam7569 Oct 1, 2019

henrykironde Oct 1, 2019 •

edited

Loading

henrykironde Oct 1, 2019

henrykironde Oct 1, 2019 •

edited

Loading

henrykironde Oct 1, 2019

henrykironde commented Oct 1, 2019

shivam7569 commented Oct 1, 2019

henrykironde commented Oct 1, 2019

shivam7569 commented Oct 1, 2019

henrykironde commented Oct 1, 2019

shivam7569 commented Oct 1, 2019 •

edited

Loading

henrykironde commented Oct 1, 2019

shivam7569 commented Oct 2, 2019 •

edited

Loading

		@@ -0,0 +1,36 @@
		{
		"citation": "Department of Innovation and Technology",

Added a script: Boston_CityHallElectricity #41

Are you sure you want to change the base?

Added a script: Boston_CityHallElectricity #41

Conversation

shivam7569 commented Oct 1, 2019

henrykironde left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

henrykironde commented Oct 1, 2019

shivam7569 commented Oct 1, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

henrykironde Oct 1, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

henrykironde Oct 1, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Boston City Hall Electricity Usage

henrykironde commented Oct 1, 2019

shivam7569 commented Oct 1, 2019

henrykironde commented Oct 1, 2019

shivam7569 commented Oct 1, 2019

henrykironde commented Oct 1, 2019

shivam7569 commented Oct 1, 2019 • edited Loading

henrykironde commented Oct 1, 2019

shivam7569 commented Oct 2, 2019 • edited Loading

henrykironde Oct 1, 2019 •

edited

Loading

henrykironde Oct 1, 2019 •

edited

Loading

shivam7569 commented Oct 1, 2019 •

edited

Loading

shivam7569 commented Oct 2, 2019 •

edited

Loading