Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cultural 10m dataset #131

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

Nageshbansal
Copy link

@Nageshbansal Nageshbansal commented Jan 18, 2022

added the cultural 1:10m dataset provided by : https://www.naturalearthdata.com/downloads/10m-cultural-vectors/

Screenshot from 2022-01-18 19-22-44

@henrykironde
Copy link
Contributor

@Nageshbansal which tables are failing?

@Nageshbansal
Copy link
Author

ne_10m_admin_1_states_provinces
ne_10m_admin_1_states_provinces_lakes
ne_10m_admin_0_countries_bdg
ne_10m_admin_2_counties
ne_10m_admin_2_counties_lakes
ne_10m_admin_0_countries_pak

@henrykironde
Copy link
Contributor

I have created an issue nvkelso/natural-earth-vector#674. Let's see if the authors of the data can help.

@Nageshbansal
Copy link
Author

Nageshbansal commented Jan 19, 2022

@henrykironde, Scripts contains updated paths now, only those falling 6 tables are remaining, can you tell me how can we proceed further now?

@henrykironde
Copy link
Contributor

We shall have to leave this PR open with hopes that the distributors of the data can change the dataset soon.

@henrykironde
Copy link
Contributor

Also when creating these scripts, do not change the structure / organization /arrangement of the keys in the file.

@Nageshbansal
Copy link
Author

@henrykironde can you please just review this PR once , and if dataset get updated then we can merge this PR.

@henrykironde
Copy link
Contributor

It looks like you may have over written the commits. Let's work on this together to get the files organized. This happens when you push always to main. We should be using other branches not main. Each issue should have a separate branch.

@Nageshbansal
Copy link
Author

Nageshbansal commented May 9, 2022

Yeah sure, should i create a new PR for this on a separate branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants