Add dataset-Chronic diseases #104

mohamedsto7y · 2021-03-29T22:59:01Z

Mohitkumar6122 · 2021-03-30T06:51:02Z

@mohamedsto7y, there is some error in your dataset added as normally after using retriever install csv ***** dataset is downloaded in csv format and output looks like :

henrykironde · 2021-03-30T07:46:55Z

scripts/chronic_disease_indicators_us.json

+        "diabetes",
+        "hypertension"
+    ],
+    "licenses": [],


license is Public Domain

henrykironde · 2021-03-30T07:50:38Z

Remember to run Python version.py
And since you want to edit the commit, after all the changes run.

git add -u
git commit --amend
# No need to change the commit message in this case
git push origin add-datasets -f

henrykironde · 2021-03-30T18:28:16Z

@mohamedsto7y thanks for the update.
The url is wrong. It should be the url of of data.
Get the url as shown in the picture under share url.

Additionally download the data again and run retriever autocreate. When I did run autocreate I notices that we have different values.

Here is my sample diff

mohamedsto7y · 2021-03-30T23:55:36Z

henrykironde · 2021-03-30T23:58:29Z

Why do you have two files? I think you need one json file

mohamedsto7y · 2021-03-31T00:12:08Z

yes I removed one and the correct is shown in versions.py

henrykironde

Let's make these changes

henrykironde · 2021-03-31T01:43:24Z

scripts/chronic_disease_indicators_in_us__cdi_.json

@@ -0,0 +1,186 @@
+{
+
+    "citation": "Centers for Disease Control and Prevention",


The citation is not included so leave this as "citation": "",

henrykironde · 2021-03-31T03:38:18Z

scripts/chronic_disease_indicators_in_us__cdi_.json

+{
+
+    "citation": "Centers for Disease Control and Prevention",
+    "description": "DC's Division of Population Health provides cross-cutting set of 124 indicators that were developed by consensus and that allows states and territories and large metropolitan areas to uniformly define, collect, and report chronic disease data that are important to public health practice and available for states, territories and large metropolitan areas. In addition to providing access to state-specific indicator data, the CDI web site serves as a gateway to additional information and data resources.CDC's Division of Population Health provides cross-cutting set of 124 indicators that were developed by consensus and that allows states and territories and large metropolitan areas to uniformly define, collect, and report chronic disease data that are important to public health practice and available for states, territories and large metropolitan areas. In addition to providing access to state-specific indicator data, the CDI web site serves as a gateway to additional information and data resources.",


"description": "124 indicators by CDC's Division of Population Health used to uniformly define, collect, and report chronic disease data"

henrykironde · 2021-03-31T14:06:01Z

Looks nice. It will test this later but I think it is ready.

mohamedsto7y · 2021-03-31T16:18:09Z

Looking forward for any update.Thank you so much!

henrykironde

I have made some comments. These could improve the data package.

I am going to make one last test after that to make sure the URL is stable

henrykironde · 2021-04-06T20:55:22Z

scripts/chronic_disease_indicators_in_us__cdi_.json

+    "encoding": "utf-8",
+    "homepage": "https://data.world/cdc/us-chronic-disease-indicators",
+    "keywords": [
+        "chronic",


add USA to keywords

henrykironde · 2021-04-06T20:56:23Z

scripts/chronic_disease_indicators_in_us__cdi_.json

+        "cardiovascular disease",
+        "public health"
+    ],
+    "name": "chronic-disease-indicators-in-us",


rename to chronic-disease-indicators-us and file name to chronic_disease_indicators_us.json

henrykironde · 2021-04-06T20:57:44Z

scripts/chronic_disease_indicators_in_us__cdi_.json

+            "dialect": {
+                "delimiter": ","
+            },
+            "name": "chronic_disease_indicators_in_us_cdi",


Rename to a simple table name like. cdi_indicators

henrykironde · 2021-04-08T21:12:43Z

What happened, looks like you did not do the commands right
The file is missing

Updated Link to Data Retriever Website

mohamedsto7y · 2021-04-27T23:52:30Z

what to fix next?

henrykironde · 2021-04-28T06:26:51Z

Thanks @mohamedsto7y. If this is working fine, could you go a head and run some commands, then paste the results here.
If you installed the data into Postgres or Mysql, you should provide a snapshot of the data just like I have been doing. Also do not forget to run python version.txt to update the version.txt

henrykironde added the Testing label Mar 30, 2021

henrykironde reviewed Mar 30, 2021

View reviewed changes

mohamedsto7y force-pushed the add-datasets branch 2 times, most recently from 2be4fe9 to 9734bf5 Compare March 30, 2021 10:35

mohamedsto7y force-pushed the add-datasets branch from 9734bf5 to db1ebf7 Compare March 30, 2021 23:51

mohamedsto7y force-pushed the add-datasets branch 2 times, most recently from 2225116 to ab57f7d Compare March 31, 2021 00:09

henrykironde reviewed Mar 31, 2021

View reviewed changes

mohamedsto7y force-pushed the add-datasets branch from ab57f7d to 01269ac Compare March 31, 2021 11:36

henrykironde reviewed Apr 6, 2021

View reviewed changes

mohamedsto7y force-pushed the add-datasets branch from 01269ac to 240bf73 Compare April 8, 2021 12:03

mohamedsto7y force-pushed the add-datasets branch from 240bf73 to a4029c1 Compare April 9, 2021 15:15

Merge pull request weecology#98 from Mohitkumar6122/Changes

b70402b

Updated Link to Data Retriever Website

mohamedsto7y force-pushed the add-datasets branch from a4029c1 to b70402b Compare April 14, 2021 12:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add dataset-Chronic diseases #104

Add dataset-Chronic diseases #104

mohamedsto7y commented Mar 29, 2021

Mohitkumar6122 commented Mar 30, 2021

henrykironde Mar 30, 2021

henrykironde commented Mar 30, 2021

henrykironde commented Mar 30, 2021

mohamedsto7y commented Mar 30, 2021

henrykironde commented Mar 30, 2021

mohamedsto7y commented Mar 31, 2021

henrykironde left a comment

henrykironde Mar 31, 2021

henrykironde Mar 31, 2021

henrykironde commented Mar 31, 2021

mohamedsto7y commented Mar 31, 2021

henrykironde left a comment

henrykironde Apr 6, 2021

henrykironde Apr 6, 2021

henrykironde Apr 6, 2021

henrykironde commented Apr 8, 2021

mohamedsto7y commented Apr 27, 2021

henrykironde commented Apr 28, 2021

		@@ -0,0 +1,186 @@
		{

		"citation": "Centers for Disease Control and Prevention",

Add dataset-Chronic diseases #104

Are you sure you want to change the base?

Add dataset-Chronic diseases #104

Conversation

mohamedsto7y commented Mar 29, 2021

Mohitkumar6122 commented Mar 30, 2021

henrykironde Mar 30, 2021

Choose a reason for hiding this comment

henrykironde commented Mar 30, 2021

henrykironde commented Mar 30, 2021

mohamedsto7y commented Mar 30, 2021

henrykironde commented Mar 30, 2021

mohamedsto7y commented Mar 31, 2021

henrykironde left a comment

Choose a reason for hiding this comment

henrykironde Mar 31, 2021

Choose a reason for hiding this comment

henrykironde Mar 31, 2021

Choose a reason for hiding this comment

henrykironde commented Mar 31, 2021

mohamedsto7y commented Mar 31, 2021

henrykironde left a comment

Choose a reason for hiding this comment

henrykironde Apr 6, 2021

Choose a reason for hiding this comment

henrykironde Apr 6, 2021

Choose a reason for hiding this comment

henrykironde Apr 6, 2021

Choose a reason for hiding this comment

henrykironde commented Apr 8, 2021

mohamedsto7y commented Apr 27, 2021

henrykironde commented Apr 28, 2021