Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peer_connection: sdp: allow inactive m= to have conflicting credentials #585

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

haaspors
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.38%. Comparing base (edf0a53) to head (50bcc80).

Files Patch % Lines
webrtc/src/peer_connection/sdp/sdp_test.rs 90.32% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #585   +/-   ##
=======================================
  Coverage   61.37%   61.38%           
=======================================
  Files         533      533           
  Lines       49679    49710   +31     
  Branches    12618    12635   +17     
=======================================
+ Hits        30489    30512   +23     
- Misses       9853     9854    +1     
- Partials     9337     9344    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rainliu rainliu merged commit 1ad10c3 into webrtc-rs:master Jun 29, 2024
5 checks passed
@haaspors haaspors deleted the fix-ice-ufrag-inactive branch June 29, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants